Bugfix: Do not create table as unlogged if it is not clustered #1521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tables created with the flex output that were marked `cluster: "no"` were created as unlogged tables. This should only be done for tables which will be replaced by their clustered copy later on. See osm2pgsql-dev#27
Collaborator
|
Do we have the ability to end up with a final table that is UNLOGGED, like the pgsql backend does? |
Collaborator
Author
|
@pnorman It does? I would consider this a bug then. |
Collaborator
|
Never mind, we removed unlogged |
pnorman
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tables created with the flex output that were marked
cluster: "no"were created as unlogged tables. This should only be done for tables
which will be replaced by their clustered copy later on.
See #27