Feat/bash completion - #317
Merged
Merged
Conversation
Member
|
This looks pretty good, found just one problem: opl|opl.gz|opl.bz2 should also be allowed as input formats. That's wrong in the zsh format already. (Guess I never added that after OPL was implemented as input format). Can you add some information in the file header on where/how to install the file? |
Contributor
Author
Added
I've just included both completions it in the make install script, does that work for you? |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a quick implementation for the bash completion (#297).
I've also added the new
query-locations-indexandcreate-locations-indexto the zsh completions, since they weren't in there before.Didn't take a stab at the fish completions, since I've never used that shell.