Skip to content

Allow Apache thrift or fbthrift#39

Closed
theopolis wants to merge 2 commits intomasterfrom
fbthrift-1
Closed

Allow Apache thrift or fbthrift#39
theopolis wants to merge 2 commits intomasterfrom
fbthrift-1

Conversation

@theopolis
Copy link
Member

There are two commits here:

  • Using a clean, Vagrant-built, copy of facebook/fbthrift, using thrift1 to compile the Python interface using the osquery-python thrift specification. Copy that output into the new directory osquery/extensions/fbthrift. This effectively accomplishes nothing because that module is unused.
  • Use the osquery.extensions.fbthrfit module as osquery.extensions when importing from . This requires a cleanup of the generated code in 1 place where the import osquery.extensions. form is used, which does not respect the sys.modules list.

The goal is to use whatever version of thrift is found first. Essentially try for fbthrift's module and fall-back to Apache.

@theopolis theopolis closed this Apr 11, 2018
@theopolis theopolis deleted the fbthrift-1 branch August 6, 2019 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant