Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two commits here:
facebook/fbthrift, usingthrift1to compile the Python interface using the osquery-python thrift specification. Copy that output into the new directoryosquery/extensions/fbthrift. This effectively accomplishes nothing because that module is unused.osquery.extensions.fbthrfitmodule asosquery.extensionswhen importingfrom. This requires a cleanup of the generated code in 1 place where theimport osquery.extensions.form is used, which does not respect thesys.moduleslist.The goal is to use whatever version of
thriftis found first. Essentially try forfbthrift's module and fall-back to Apache.