Feature/remove default arguments warning for volume extension#292
Feature/remove default arguments warning for volume extension#292
Conversation
…ult_arguments_warning
|
Oh sorry. I was not up to date with master where you already fixed this. I guess this pr is just adding type hints now. |
tfoote
left a comment
There was a problem hiding this comment.
Thanks for the attention to clear the warning. Sorry we had the collision on fixing it. But adding the type annotations sounds good.
PS would you be willing to add some of your rocker extensions to this list? https://github.com/osrf/rocker?tab=readme-ov-file#externally-maintained-extensions
|
Yes, I'm happy to add my rocker extension to the list. I was holding off because I'm still getting my head around things and didn't want to advertise them in case I needed to make any breaking changes. In fact today I was considering making a meta-package that includes all the rocker extensions but I need to think through all the tradeoffs before I go ahead with that. |
when running rocker this warning appears every time:
Extension volume doesn't support default arguments. Please extend it.This sets default arguments for the volume extension to remove this warning.
It also adds type hints for the parser argument.