Conversation
tfoote
commented
Jan 28, 2025
ahcorde
reviewed
Jan 29, 2025
Contributor
ahcorde
left a comment
ahcorde
left a comment
There was a problem hiding this comment.
I will leave this comment here:
zenoh requires to launch the zenoh router. Can we add a flag to launch the zenoh route too ?
Collaborator
Author
|
Yeah we can do that, but lets add it separately. There's a level of coordination needed potentially to make sure that there's only one router if there's multiple containers running etc. |
tfoote
force-pushed
the
rmw_zenoh_support
branch
from
7c84f4c to
b1f6af7
Compare
Also parameterize tests automatically
tfoote
force-pushed
the
rmw_zenoh_support
branch
from
b1f6af7 to
7cd63bf
Compare
nuclearsandwich
approved these changes
Feb 4, 2025
| @(' '.join(packages)) \ | ||
| && apt-get clean ;\ | ||
| @[for package in packages]@ | ||
| apt-get update ;\ |
Contributor
There was a problem hiding this comment.
Minor nit: doing the apt-get update and apt-get clean as setup and teardown to the loop would cut down on timing. It's not important while the loop size is usually 1.
And only clean up once so repeated calls will hit the cache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #307