Enable redirecting non-interactive run console output to file#317
Merged
Enable redirecting non-interactive run console output to file#317
Conversation
tfoote
added a commit
to opencv/bpc
that referenced
this pull request
Jan 30, 2025
nuclearsandwich
approved these changes
Jan 31, 2025
Comment on lines
+404
to
+410
| with open(console_output_file, 'a') if console_output_file else nullcontext() as consoleout_fh: | ||
| if console_output_file: | ||
| print(f"Logging output to file {console_output_file}") | ||
| print("Executing command: ") | ||
| print(cmd) | ||
| p = subprocess.run(shlex.split(cmd), check=True, stdout=consoleout_fh if console_output_file else None, stderr=subprocess.STDOUT) | ||
| return p.returncode |
Contributor
There was a problem hiding this comment.
This was my first time seeing nullcontext. I'm not sure if I love it but I juggled a few different methods for handling this and all were more error prone than using the context manager unconditionally.
Collaborator
Author
There was a problem hiding this comment.
Yeah, i did a bunch of searching on it and it eventually seemed like the best way to not have two branches of almost duplicate code.
AllProAi
pushed a commit
to AllProAi/bpc
that referenced
this pull request
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.