Skip to content

Detect missing base image (fix #26)#344

Merged
tfoote merged 3 commits intoosrf:mainfrom
SarthakBagga:improve_base_image_error
Jan 27, 2026
Merged

Detect missing base image (fix #26)#344
tfoote merged 3 commits intoosrf:mainfrom
SarthakBagga:improve_base_image_error

Conversation

@SarthakBagga
Copy link
Contributor

Fixes #26.

This adds an early check for the base Docker image before running the OS detector or any extensions.

If the image is missing locally, Rocker now:

  • Attempts an implicit docker pull with user feedback.
  • Fails early with a clear error if the image does not exist.
  • Re-raises real Docker errors (network/auth/daemon) instead of hiding them.

This prevents extensions (including nvidia) from crashing on non-existent images and avoids long silent startups.

Testing:

  • Missing image → early clear error after failed pull.
  • Image not local but exists remotely → pulled and proceeds normally.

@SarthakBagga SarthakBagga requested a review from tfoote as a code owner January 27, 2026 13:25
@SarthakBagga
Copy link
Contributor Author

Please let me know if you’d like any changes or improvements to this approach.

Signed-off-by: Tully Foote <tullyfoote@intrinsic.ai>
Copy link
Collaborator

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've added a quick unit test to make sure we have some coverage of the logic.

@tfoote tfoote merged commit f0eca6c into osrf:main Jan 27, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

detect a base image doesn't exist and give a good error message

2 participants