Document TimeSource class #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
ivanpauno
approved these changes
Aug 25, 2020
Collaborator
ivanpauno
left a comment
ivanpauno
left a comment
There was a problem hiding this comment.
LGTM!
My two comments can be safely ignored.
ivanpauno
approved these changes
Aug 25, 2020
rcljava/src/test/java/org/ros2/rcljava/time/TimeSourceTest.java
Outdated
Show resolved
Hide resolved
* Empty -> Default * Add more detail to class docblock Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
force-pushed
the
jacob/document_time_source
branch
from
bf546a2 to
2907d29
Compare
ivanpauno
approved these changes
Aug 25, 2020
jacobperron
added a commit
that referenced
this pull request
Sep 18, 2020
* Document TimeSource class Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Address feedback * Empty -> Default * Add more detail to class docblock Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
Sep 18, 2020
* Document TimeSource class Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Address feedback * Empty -> Default * Add more detail to class docblock Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
Sep 18, 2020
* Document TimeSource class Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Address feedback * Empty -> Default * Add more detail to class docblock Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
Sep 18, 2020
* Document TimeSource class Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Address feedback * Empty -> Default * Add more detail to class docblock Signed-off-by: Jacob Perron <jacob@openrobotics.org>
ivanpauno
pushed a commit
that referenced
this pull request
May 17, 2021
* Document TimeSource class Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Address feedback * Empty -> Default * Add more detail to class docblock Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
to ros2-java/ros2_java
that referenced
this pull request
May 13, 2022
* Document TimeSource class Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Address feedback * Empty -> Default * Add more detail to class docblock Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
to ros2-java/ros2_java
that referenced
this pull request
May 13, 2022
* Document TimeSource class Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Address feedback * Empty -> Default * Add more detail to class docblock Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
to ros2-java/ros2_java
that referenced
this pull request
May 17, 2022
* Document TimeSource class Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Address feedback * Empty -> Default * Add more detail to class docblock Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding API documentation for the TimeSource class.