Skip to content

Support wall-time and ROS-time timers #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 18, 2020
Merged

Support wall-time and ROS-time timers #39

merged 3 commits into from
Sep 18, 2020

Conversation

@jacobperron
Copy link

@jacobperron jacobperron commented Sep 17, 2020

Add a new method to Node for creating ROS timers.

Refactor timer implementation to account for the two different types of timers.
Deprecate WallTimer interface and WallTimerImpl and replace with unified Timer interface and TimerImpl.

@jacobperron
Support wall-time and ROS-time timers
313467b 
Add a new method to Node for creating ROS timers.

Refactor timer implementation to account for the two different types of timers.
Deprecate WallTimer interface and WallTimerImpl and replace with unified Timer interface and TimerImpl.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Author

jacobperron commented Sep 17, 2020

Note, the only new implementation is Node.createTimer. The rest is just renaming classes WallTimer* -> Timer*.

@jacobperron
Add test
5a6f73d 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
ivanpauno
ivanpauno approved these changes Sep 18, 2020
View reviewed changes
Copy link
Collaborator

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jacobperron
Log error if failed to dispose timer
82cfc57 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron merged commit 2c2b68b into feature/ros_time Sep 18, 2020
@jacobperron jacobperron deleted the ros_timers branch September 18, 2020 18:33
jacobperron added a commit that referenced this pull request Sep 18, 2020
@jacobperron
Support wall-time and ROS-time timers (#39)
d8695ae 
* Support wall-time and ROS-time timers

Add a new method to Node for creating ROS timers.

Refactor timer implementation to account for the two different types of timers.
Deprecate WallTimer interface and WallTimerImpl and replace with unified Timer interface and TimerImpl.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Add test

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Log error if failed to dispose timer

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron added a commit that referenced this pull request Sep 18, 2020
@jacobperron
Support wall-time and ROS-time timers (#39)
13bb5a5 
* Support wall-time and ROS-time timers

Add a new method to Node for creating ROS timers.

Refactor timer implementation to account for the two different types of timers.
Deprecate WallTimer interface and WallTimerImpl and replace with unified Timer interface and TimerImpl.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Add test

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Log error if failed to dispose timer

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron added a commit that referenced this pull request Sep 18, 2020
@jacobperron
Support wall-time and ROS-time timers (#39)
7f78e79 
* Support wall-time and ROS-time timers

Add a new method to Node for creating ROS timers.

Refactor timer implementation to account for the two different types of timers.
Deprecate WallTimer interface and WallTimerImpl and replace with unified Timer interface and TimerImpl.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Add test

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Log error if failed to dispose timer

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron added a commit that referenced this pull request Sep 18, 2020
@jacobperron
Support wall-time and ROS-time timers (#39)
753cea7 
* Support wall-time and ROS-time timers

Add a new method to Node for creating ROS timers.

Refactor timer implementation to account for the two different types of timers.
Deprecate WallTimer interface and WallTimerImpl and replace with unified Timer interface and TimerImpl.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Add test

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Log error if failed to dispose timer

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
ivanpauno pushed a commit that referenced this pull request May 17, 2021
@jacobperron @ivanpauno
Support wall-time and ROS-time timers (#39)
df24a5b 
* Support wall-time and ROS-time timers

Add a new method to Node for creating ROS timers.

Refactor timer implementation to account for the two different types of timers.
Deprecate WallTimer interface and WallTimerImpl and replace with unified Timer interface and TimerImpl.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Add test

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Log error if failed to dispose timer

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron added a commit to ros2-java/ros2_java that referenced this pull request May 13, 2022
@jacobperron
Support wall-time and ROS-time timers (osrf#39)
1b59765 
* Support wall-time and ROS-time timers

Add a new method to Node for creating ROS timers.

Refactor timer implementation to account for the two different types of timers.
Deprecate WallTimer interface and WallTimerImpl and replace with unified Timer interface and TimerImpl.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Add test

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Log error if failed to dispose timer

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron added a commit to ros2-java/ros2_java that referenced this pull request May 13, 2022
@jacobperron
Support wall-time and ROS-time timers (osrf#39)
38c8df4 
* Support wall-time and ROS-time timers

Add a new method to Node for creating ROS timers.

Refactor timer implementation to account for the two different types of timers.
Deprecate WallTimer interface and WallTimerImpl and replace with unified Timer interface and TimerImpl.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Add test

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Log error if failed to dispose timer

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron added a commit to ros2-java/ros2_java that referenced this pull request May 13, 2022
@jacobperron
Support wall-time and ROS-time timers (osrf#39)
3ce66d8 
* Support wall-time and ROS-time timers

Add a new method to Node for creating ROS timers.

Refactor timer implementation to account for the two different types of timers.
Deprecate WallTimer interface and WallTimerImpl and replace with unified Timer interface and TimerImpl.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Add test

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Log error if failed to dispose timer

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron added a commit to ros2-java/ros2_java that referenced this pull request May 17, 2022
@jacobperron
Support wall-time and ROS-time timers (osrf#39)
6cfc727 
* Support wall-time and ROS-time timers

Add a new method to Node for creating ROS timers.

Refactor timer implementation to account for the two different types of timers.
Deprecate WallTimer interface and WallTimerImpl and replace with unified Timer interface and TimerImpl.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Add test

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Log error if failed to dispose timer

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jacobperron @ivanpauno