Skip to content

Added namespace constructor to BaseComposableNode #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Added namespace constructor to BaseComposableNode #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions rcljava/src/main/java/org/ros2/rcljava/node/BaseComposableNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ public BaseComposableNode(String name) {
node = RCLJava.createNode(this.name);
}

public BaseComposableNode(String name, String namespace) {
this.name = name;
Copy link
Collaborator

@ivanpauno ivanpauno Apr 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.name can be deleted from the class, as it's not used.
I will ignore that in this review because it's unrelated to the PR.

node = RCLJava.createNode(name, namespace);
}

public Node getNode() {
return node;
}
Expand Down