Added namespace constructor to BaseComposableNode #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanpauno
approved these changes
Apr 14, 2021
| } | ||
|
|
||
| public BaseComposableNode(String name, String namespace) { | ||
| this.name = name; |
Collaborator
There was a problem hiding this comment.
this.name can be deleted from the class, as it's not used.
I will ignore that in this review because it's unrelated to the PR.
ivanpauno
pushed a commit
that referenced
this pull request
May 17, 2021
Co-authored-by: Julius Gyorfi <julius.s.gyorfi@nasa.gov>
jacobperron
pushed a commit
to ros2-java/ros2_java
that referenced
this pull request
May 17, 2022
Co-authored-by: Julius Gyorfi <julius.s.gyorfi@nasa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added another constructor to BaseComposableNode.java to enable namespacing.