Skip to content

Conversation

@ivanpauno
Copy link
Collaborator

Replaces #66 (I opened that one in a fork by accident).

I hope this workflow config works 😬

@ivanpauno ivanpauno added the enhancement New feature or request label May 13, 2021
@ivanpauno ivanpauno requested a review from jacobperron May 13, 2021 18:54
@ivanpauno ivanpauno self-assigned this May 13, 2021
@ivanpauno
Copy link
Collaborator Author

If we need to specify -target -source in Android as commented here, we can readd that in the future.

I'm using --release in the github workflows, because it does the right thing TM.
See https://stackoverflow.com/questions/43102787/what-is-the-release-flag-in-the-java-9-compiler.

@jacobperron jacobperron mentioned this pull request May 13, 2021
@ivanpauno
Copy link
Collaborator Author

mmm, not sure why the build failed, I'm going to double check

@ivanpauno
Copy link
Collaborator Author

ivanpauno commented May 13, 2021

Well, actually our code is not fully compatible with java 6 (java.time.Duration doesn't exist).
--release 6 is more strict that passing -source 1.6 -target 1.6.

I will use the later, because I think that java.time.Duration is available in android anyways ... (either through the ThreeTen backport or through the android gradle 4.0 plugin).

@ivanpauno
Copy link
Collaborator Author

CI now looks ok (same failure that we were having before and that #70 should fix 😃 )

@jacobperron jacobperron force-pushed the ivanpauno/fix-source-6-warnings branch from 70c9b2a to 03e9d5e Compare June 22, 2021 22:52
Copy link

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased the changes.

@jacobperron
Copy link

#76 should fix the infrastructure issue.

ivanpauno added 6 commits July 2, 2021 13:15
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno force-pushed the ivanpauno/fix-source-6-warnings branch from 03e9d5e to 2688e4e Compare July 2, 2021 16:15
@ivanpauno
Copy link
Collaborator Author

Rebasing again after #76 was merged.

@ivanpauno ivanpauno merged commit b025c1e into galactic-devel Jul 2, 2021
@ivanpauno ivanpauno deleted the ivanpauno/fix-source-6-warnings branch July 2, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants