-
Notifications
You must be signed in to change notification settings - Fork 9
Fix source 6 warnings #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
If we need to specify I'm using |
|
mmm, not sure why the build failed, I'm going to double check |
|
Well, actually our code is not fully compatible with java 6 ( I will use the later, because I think that |
|
CI now looks ok (same failure that we were having before and that #70 should fix 😃 ) |
70c9b2a to
03e9d5e
Compare
jacobperron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've rebased the changes.
|
#76 should fix the infrastructure issue. |
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
03e9d5e to
2688e4e
Compare
|
Rebasing again after #76 was merged. |
Replaces #66 (I opened that one in a fork by accident).
I hope this workflow config works 😬