Skip to content

Conversation

@ivanpauno
Copy link
Collaborator

This fixes many of the existing java warnings.

There's no more deprecation warnings after this patch.
There are still some "unchecked" warnings to go.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the bug Something isn't working label May 14, 2021
@ivanpauno ivanpauno requested a review from jacobperron May 14, 2021 19:51
@ivanpauno ivanpauno self-assigned this May 14, 2021
Copy link

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivanpauno ivanpauno merged commit 7b00bbf into galactic-devel May 17, 2021
@ivanpauno ivanpauno deleted the ivanpauno/fix-some-java-warnings branch May 17, 2021 19:06
ivanpauno added a commit that referenced this pull request May 17, 2021
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron pushed a commit to ros2-java/ros2_java that referenced this pull request May 17, 2022
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants