[3.x] Fix schema rejection of function-level vpc opt-out - #433
Merged
Conversation
Co-authored-by: BenjaminBurgalat <b.burgalat@betclicgroup.com>
GrahamCampbell
changed the title
vpc opt-out (3.x)vpc opt-out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This applies the same fix as #432 to the
3.xbranch, where the schema/compile mismatch is also present (refs #421). The compile step has deliberately supported opting a single function out ofprovider.vpcwithvpc: falseorvpc: null(documented asvpc: ~) since 2021, but the schema only accepts a VPC config object, sovpc: falseproduces a spurious validation warning under the defaultconfigValidationMode: warnand a hard failure for services that opt intoerror.The function-level
vpcschema now acceptsfalseandnullalongside the config object, both guides mentionfalsealongside~, and a regression test asserts a function withvpc: falseis packaged without aVpcConfigunder strict validation. Thanks to @bburgalat-bcg for the diagnosis and the original patch, credited as co-author.