[4.x] Fix YAML parsing of existing stack templates - #447
Merged
Conversation
GrahamCampbell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deployment bucket repair path fetches an existing stack's original template and falls back to a YAML parse when it is not JSON, but that parse used js-yaml's default schema instead of the shared CloudFormation schema. Date-shaped scalars such as an IAM policy
VersionbecameDateobjects and were re-submitted as ISO 8601 strings, and any template using shorthand intrinsics like!Reffailed withCLOUDFORMATION_TEMPLATE_PARSE_FAILED. This passes the shared schema at that call site, mirroring #441, and includes the underlying parse error in the message. The existing YAML repair tests now cover a shorthand tag and a date-shaped value, and a new test covers the parse failure path. #448 applies the same change to 3.x. Fixes #443.