Retry throttled AWS calls after stack deployment - #449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the stack reaches
UPDATE_COMPLETE,deploystill issues CloudFormation, Lambda, API Gateway, and S3 calls to gather stack info, prune old versions, apply deletion protection and the stack policy, and clean up old artifacts. Those calls only had the SDK's five attempts, roughly four seconds of backoff on average, where v3 retried every call four more times with four to seven second backoff. Under sustained throttling from many concurrent deploys they fail withRate exceededand the CLI exits non-zero although the stack deployed. This wraps those calls in theretryOnThrottlingErrorhelper that already protects stack polling, change set polling, and artifact uploads, and replaces the S3 list paginator with an explicit loop so each page is retried. Fixes #436.