wpa_supplicant checker #1134
Merged
wpa_supplicant checker #1134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terriko
requested changes
Apr 14, 2021
Collaborator
terriko
left a comment
terriko
left a comment
There was a problem hiding this comment.
Looking good! Could you add the condensed download file for the centos package to the pull request? Plus I've made a suggestion about removing the shebang line so we don't have to remove it later, although that's less essential.
| # Copyright (C) 2021 Intel Corporation | ||
| # SPDX-License-Identifier: GPL-3.0-or-later | ||
|
|
||
| #!/usr/bin/python3 |
Collaborator
There was a problem hiding this comment.
Suggested change
| #!/usr/bin/python3 |
Per #1123 we're going to be getting rid of these, might as well just not commit the shebang line in the first place!
Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wpa_supplicantchecker