-
Notifications
You must be signed in to change notification settings - Fork 582
feat: human readable sbom integration #2893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this commit adds a build process for SBOM markdown files triggered by the docs build process.
|
fixes issue #2850 |
|
Approving tests to run now. This looks like what I was hoping for, but I'll let the linters and stuff do their job before coming back to review. |
|
I've not added to the |
terriko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to edit the doc/requirements.csv to add sbom2doc. The csv filet gives us a place to add the {vendor, product} pair for looking up CVEs. In this case, I'm rather sure sbom2doc doesn't have any yet, so you'd probably use the following pair in the file, similar to what I did in the main requirements.csv file:
anthonyharrison_not_in_db,sbom2doc
|
Approving tests to run again. I think this should be the last time and we might be ready to merge, but I'll let the tests do their work first. |
terriko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we're ready to merge! Thanks for iterating on this one a few times as we figured out the best way to do it, and congratulations on your first merged commit!
|
Thank you! |
this commit adds a build process for SBOM markdown files triggered by the docs build process.
From your review in the previous implementation:
The
sbom/Makefileis triggered indoc/Makefile.I like this one!