Skip to content

Conversation

@Niraj-Kamdar
Copy link
Contributor

@Niraj-Kamdar Niraj-Kamdar commented Jun 30, 2020

test_json can now be run in parallel with pytest -n 4 test/test_json.py:

=================================================== 19 passed, 4 warnings in 85.99s (0:01:25) ====================================================

It is significantly faster now. Past implementation was taking roughly 10 minutes to run.

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2020

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.31%. Comparing base (ca4b2d9) to head (e560fb3).

Files with missing lines Patch % Lines
test/test_json.py 85.71% 3 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #772      +/-   ##
==========================================
- Coverage   88.33%   88.31%   -0.03%     
==========================================
  Files         137      137              
  Lines        2478     2473       -5     
  Branches      302      301       -1     
==========================================
- Hits         2189     2184       -5     
  Misses        225      225              
  Partials       64       64              
Flag Coverage Δ
longtests 88.31% <85.71%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@terriko
Copy link
Collaborator

terriko commented Jun 30, 2020

This is a great improvement, thank you!

@terriko terriko merged commit 53e2914 into ossf:master Jun 30, 2020
@Niraj-Kamdar Niraj-Kamdar deleted the test branch July 1, 2020 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants