Skip to content

Comments

Delete specification/Secure_Supply_Chain_Consumption_Framework_(S2C2F…#45

Merged
adriandiglio merged 1 commit intomainfrom
camaleon2016-patch-3
Apr 9, 2024
Merged

Delete specification/Secure_Supply_Chain_Consumption_Framework_(S2C2F…#45
adriandiglio merged 1 commit intomainfrom
camaleon2016-patch-3

Conversation

@camaleon2016
Copy link
Member

…).pdf

This appears to be corrupted and there is another formatted file to take its place.

…).pdf

This appears to be corrupted and there is another formatted file to take its place.

Signed-off-by: Jay White <103074150+camaleon2016@users.noreply.github.com>
Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per my comment in #44 I think it would be better not to store PDFs in the GitLab repo and instead generate them in a GitHub Action from the Markdown as changes are introduced.

@camaleon2016
Copy link
Member Author

I agree. What do we think about having 2 markdowns? One as it stands currently but the other for the ISO Formatted Draft?

@joshuagl
Copy link
Member

joshuagl commented Apr 8, 2024

If the current one is fixed you could tag a release, generate a PDF from it, and link to the static (released) version from anywhere you want folks to reference the non-draft version.

@adriandiglio
Copy link
Contributor

Since this PR is just deleting the existing PDF that has issues, let's approve. Futurue PDFs will be generated in an automated fashion

Copy link
Contributor

@adriandiglio adriandiglio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the README to remove the link to the PDF. We can add it back when we're ready

@adriandiglio adriandiglio merged commit ca4201e into main Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants