Skip to content

Revising Vuln Management controls based on feedback#205

Merged
eddie-knight merged 7 commits intoossf:mainfrom
eddie-knight:feat/merge-sca
Feb 24, 2025
Merged

Revising Vuln Management controls based on feedback#205
eddie-knight merged 7 commits intoossf:mainfrom
eddie-knight:feat/merge-sca

Conversation

@eddie-knight
Copy link
Contributor

@eddie-knight eddie-knight commented Feb 22, 2025

  • merged SCA requirements into one control
  • added requirements so that SAST and SCA are handled similarly
  • renumbered the resulting SCA control to the bottom, a stylistic pre-release choice since all of these requirements are level
  • added an explicit requirement for VEX at level 3
  • also I'm pretty sure the impacted controls mappings are irreparably jankified, I'm sorry @SecurityCRob

@eddie-knight eddie-knight changed the title merged SCA requirements into one control Revising Vuln Management controls based on feedback Feb 22, 2025
Signed-off-by: Eddie Knight <knight@linux.com>
Signed-off-by: Eddie Knight <knight@linux.com>
Signed-off-by: Eddie Knight <knight@linux.com>
Copy link
Contributor

@TheFoxAtWork TheFoxAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 spelling correction. LGTM

Co-authored-by: Emily Fox <33327273+TheFoxAtWork@users.noreply.github.com>
Signed-off-by: Eddie Knight <knight@linux.com>
Copy link
Contributor

@funnelfiasco funnelfiasco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

Copy link
Member

@puerco puerco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal with vex should be to provide a stream of machine-readable data of non-exploitability while, at the same time, discouraging human content (PDFs, blog posts) as the only messaging channel for false positive data. But we should only require it when it needs to exist.

I suggested some changes below, feel free to english them good 👇

eddie-knight and others added 3 commits February 24, 2025 10:28
Co-authored-by: Puerco <puerco@users.noreply.github.com>
Signed-off-by: Eddie Knight <knight@linux.com>
Co-authored-by: Puerco <puerco@users.noreply.github.com>
Signed-off-by: Eddie Knight <knight@linux.com>
@eddie-knight eddie-knight merged commit fcc7d01 into ossf:main Feb 24, 2025
3 checks passed
@eddie-knight eddie-knight deleted the feat/merge-sca branch February 24, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants