Conversation
osteele
force-pushed
the
windows
branch
6 times, most recently
from
9165c91 to
da13d1a
Compare
This commit fixes the last two Windows-specific test failures:
1. Fixed TestParseAndRun (link tag path lookup failure)
- site/site.go: Normalize input path separators in FilePathPage()
- The {% link %} tag passes paths with forward slashes (e.g., _c1/c1p1.md)
- On Windows, filepath.Rel() returns backslashes, causing comparison to fail
- Solution: Use filepath.FromSlash() to normalize input before comparison
- This matches Jekyll behavior: templates use / but files use OS paths
2. Fixed TestRemoveEmptyDirectories (Windows ERROR_DIR_NOT_EMPTY)
- utils/ioutil.go: Check for Windows syscall.ERROR_DIR_NOT_EMPTY
- Created platform-specific build files (ioutil_windows.go, ioutil_unix.go)
- Unix systems use ENOTEMPTY, Windows uses ERROR_DIR_NOT_EMPTY
- The IsNotEmpty() function now checks for both error codes
- Platform-specific files needed because ERROR_DIR_NOT_EMPTY is Windows-only
All tests now pass on macOS, Linux, and Windows.
Related to #31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.