Skip to content

Rangement des concerns - #4185

Merged
arnaudlevy merged 4 commits into
files-step-1from
clean-concerns
Jul 7, 2026
Merged

Rangement des concerns#4185
arnaudlevy merged 4 commits into
files-step-1from
clean-concerns

Conversation

@arnaudlevy

@arnaudlevy arnaudlevy commented Jul 6, 2026

Copy link
Copy Markdown
Member

Type

  • Nouvelle fonctionnalité
  • Bug
  • Ajustement
  • Rangement

Description

Renommage des derniers With...

À décider :

  • Tentative d'organisation par nature (as, has, localizable, publishable)
  • Ajout d'une configuration pour charger les concerns quel que soit le répertoire

-> non, on laisse à plat

Niveau d'incidence

  • Incidence faible 😌
  • Incidence moyenne 😲
  • Incidence forte 😱

@qltysh

qltysh Bot commented Jul 6, 2026

Copy link
Copy Markdown

All good ✅

@SebouChu

SebouChu commented Jul 6, 2026

Copy link
Copy Markdown
Member

tout remis au 1er niveau (vu avec PA), mais les noms sont meilleurs

@arnaudlevy
arnaudlevy merged commit 873d404 into files-step-1 Jul 7, 2026
5 checks passed
@arnaudlevy
arnaudlevy deleted the clean-concerns branch July 7, 2026 05:31
arnaudlevy added a commit that referenced this pull request Jul 16, 2026
* Infrastructure

Co-authored-by: Sébastien Gaya <sebastien.gaya@gmail.com>

* Icons

* created by

* interface component file

* Factorisation (non testée)

* wip

* fix

* nouveau composant FileUploadInput

* wip

* Premier flux

* rename badly named concerns

* working loop

* all in library directory

* common contexts

* tidy photo imports

* wip

* migration

* Rangement des concerns (#4185)

* group by nature

* order

* move to first-level concerns

---------

Co-authored-by: Sébastien Gaya <sebastien.gaya@gmail.com>

* fixes

* Update config/locales/vue/en.yml

* Update app/models/communication/block/template/file.rb

* Update app/javascript/apps/blocks-editor/components/inputs/FileUploadInput.vue

* Update app/models/communication/file/localization.rb

* no need for a new language param

* Update app/models/communication/block/with_communication_files.rb

* fix

* schema

* migration job

* communication_file_id

* service

* fix migration service

* handle contexts

* if no l10n found with checksum, try to find a file with a l10n with the same checksum and different lang

* keep signed_id

* style

* style

* name

* text/plain

* old i18n

* fix

* fix

* check if all files are localized in block

* fixs

* simpler

* Fix #4201

---------

Co-authored-by: Sébastien Gaya <sebastien.gaya@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants