Skip to content

Conversation

@domenic
Copy link
Contributor

@domenic domenic commented Jul 18, 2025

Includes: selenium-webdriver, cucumber-rails, brakeman, bullet, database_cleaner, factory_bot_rails, faker, i18n-tasks, rspec dependencies, vcr, webmock, timecop, n_plus_one_control, simplecov-cobertura, pry-byebug.

Excludes:

  • cucumber: latest version is incompatible with cucumber-rails
  • email_spec: pinned in Gemfile
  • rspec-rails: pinned in Gemfile
  • launchy: needs newer email_spec
  • rails-i18n: version 7.0.10 causes lots of "uninitialized constant" errors

Pull Request Checklist

  • Have you read "How to write the perfect pull request"?
  • Have you read the contributing guidelines?
  • Have you added tests for any changed functionality? If the existing test suite passes, we should be good. (I've run a subset of the tests locally; we'll see what CI says.)
  • Have you added the Jira issue number
    as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
  • Do you have fewer than 5 pull requests already open? If not, please wait
    until they are reviewed and merged before creating new pull requests.

Issue

https://otwarchive.atlassian.net/browse/AO3-7064

Purpose

Updates most test-related gems. This might help unblock #5275, but even if it doesn't, it's a good idea anyway, so I wanted to contribute it.

Testing Instructions

This should not require manual QA, as long as the continuous integration test suite keeps passing.

Credit

Domenic Denicola, he/him

@domenic
Copy link
Contributor Author

domenic commented Jul 18, 2025

Well, I swear they worked locally when run in Docker... This'll be fun to debug.

@domenic domenic marked this pull request as draft July 18, 2025 04:52
@domenic domenic marked this pull request as ready for review July 22, 2025 05:39
@Bilka2
Copy link
Contributor

Bilka2 commented Jul 22, 2025

Thank you! Could you update the files in https://github.com/otwcode/otwarchive/tree/master/config/locales/rails-i18n according to https://github.com/otwcode/otwarchive/blob/master/config/locales/README.md to the rails-i18n version you're updating to here?

You are also welcome to try to unpin and update email_spec and rspec-rails, neither of these two gems need to be pinned. But no worries if you'd rather leave them as is.

Includes: selenium-webdriver, cucumber-rails, brakeman, bullet, database_cleaner, factory_bot_rails, faker, i18n-tasks, rspec dependencies, vcr, webmock, timecop, n_plus_one_control, simplecov-cobertura, pry-byebug.

Excludes:

* cucumber: latest version is incompatible with cucumber-rails
* email_spec: pinned in Gemfile
* rspec-rails: pinned in Gemfile
* launchy: needs newer email_spec
* rails-i18n: version 7.0.10 causes lots of "uninitialized constant" errors
@domenic
Copy link
Contributor Author

domenic commented Jul 23, 2025

I ended up not updating rails-18n due to some errors I got immediately on CI when doing so. Although the fact that I missed that process probably explains the problem!

I started trying to upgrade email_spec and rspec-rails, but then it pulled along a whole rails upgrade, so I'm a bit nervous. I think it's best to just land this as-is, if possible :)

@Bilka2
Copy link
Contributor

Bilka2 commented Jul 23, 2025

There's still a rails-i18n update from 7.0.8 to 7.0.9 in the Gemfile.lock and the files we have for mr are definitely outdated for that version - that's why I asked for the update

@domenic
Copy link
Contributor Author

domenic commented Jul 24, 2025

Sorry for misunderstanding!

I gave the update a try, although I can't figure out how to re-run the search test to see if it's flaky. (Probably I'm lacking permissions?)

You can also see the commits where I tried to go to 7.0.10 but got mysterious CI-only errors.

@Bilka2
Copy link
Contributor

Bilka2 commented Jul 24, 2025

Yep, only AD&T senior volunteers can rerun tests. I've kicked them for you and they pass now.

Thanks for the file update!

@brianjaustin brianjaustin merged commit 2271fae into otwcode:master Jul 25, 2025
29 checks passed
marcus8448 added a commit to marcus8448/otwarchive that referenced this pull request Jan 20, 2026
the only thing that is different is trailing newlines - looks like it was done in otwcode#5277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants