-
Notifications
You must be signed in to change notification settings - Fork 662
AO3-7064 Update most test-related gems #5277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Well, I swear they worked locally when run in Docker... This'll be fun to debug. |
|
Thank you! Could you update the files in https://github.com/otwcode/otwarchive/tree/master/config/locales/rails-i18n according to https://github.com/otwcode/otwarchive/blob/master/config/locales/README.md to the rails-i18n version you're updating to here? You are also welcome to try to unpin and update email_spec and rspec-rails, neither of these two gems need to be pinned. But no worries if you'd rather leave them as is. |
Includes: selenium-webdriver, cucumber-rails, brakeman, bullet, database_cleaner, factory_bot_rails, faker, i18n-tasks, rspec dependencies, vcr, webmock, timecop, n_plus_one_control, simplecov-cobertura, pry-byebug. Excludes: * cucumber: latest version is incompatible with cucumber-rails * email_spec: pinned in Gemfile * rspec-rails: pinned in Gemfile * launchy: needs newer email_spec * rails-i18n: version 7.0.10 causes lots of "uninitialized constant" errors
|
I ended up not updating rails-18n due to some errors I got immediately on CI when doing so. Although the fact that I missed that process probably explains the problem! I started trying to upgrade email_spec and rspec-rails, but then it pulled along a whole rails upgrade, so I'm a bit nervous. I think it's best to just land this as-is, if possible :) |
|
There's still a rails-i18n update from 7.0.8 to 7.0.9 in the Gemfile.lock and the files we have for mr are definitely outdated for that version - that's why I asked for the update |
|
Sorry for misunderstanding! I gave the update a try, although I can't figure out how to re-run the You can also see the commits where I tried to go to 7.0.10 but got mysterious CI-only errors. |
|
Yep, only AD&T senior volunteers can rerun tests. I've kicked them for you and they pass now. Thanks for the file update! |
the only thing that is different is trailing newlines - looks like it was done in otwcode#5277
Includes: selenium-webdriver, cucumber-rails, brakeman, bullet, database_cleaner, factory_bot_rails, faker, i18n-tasks, rspec dependencies, vcr, webmock, timecop, n_plus_one_control, simplecov-cobertura, pry-byebug.
Excludes:
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7064
Purpose
Updates most test-related gems. This might help unblock #5275, but even if it doesn't, it's a good idea anyway, so I wanted to contribute it.
Testing Instructions
This should not require manual QA, as long as the continuous integration test suite keeps passing.
Credit
Domenic Denicola, he/him