AO3-7106 Refactor UsersController/ProfileController#5339
Merged
brianjaustin merged 2 commits intootwcode:masterfrom Oct 11, 2025
Merged
AO3-7106 Refactor UsersController/ProfileController#5339brianjaustin merged 2 commits intootwcode:masterfrom
brianjaustin merged 2 commits intootwcode:masterfrom
Conversation
WelpThatWorked
force-pushed
the
AO3-7106
branch
3 times, most recently
from
15c66fb to
698d699
Compare
brianjaustin
approved these changes
Sep 24, 2025
WelpThatWorked
force-pushed
the
AO3-7106
branch
from
698d699 to
87e3f44
Compare
brianjaustin
approved these changes
Sep 25, 2025
Hamham6
reviewed
Sep 25, 2025
Contributor
Hamham6
left a comment
Hamham6
left a comment
There was a problem hiding this comment.
Nonblocking, but since you're already here I think people've been cleaning up this particular mismatch as they come across it?
Separate profiles and users more, move profile edit paths to the profile controller, and user edit tests out of the profile test file.
WelpThatWorked
force-pushed
the
AO3-7106
branch
from
87e3f44 to
0b94928
Compare
Cubostar
pushed a commit
to Cubostar/otwarchive
that referenced
this pull request
Oct 14, 2025
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-7106
Purpose
- Move
#editand#updatefromUsersControllertoProfileController- Merge
edit_header_navigationand unusededit_user_navigation. Now displaysEdit My ProfileorEdit Profilewhere appropriate.- Site title and header text are still inconsistent, always displaying
Edit ProfileandEdit My Profilerespectively.- Move
UserControllerrelated tests fromprofile_edit.featuretouser_edit.feature, rewrite to not navigate through the profile page.Credit
WelpThatWorked