AO3-7124 Fix chapter numbering in PDF downloads for chapters with custom titles#5387
Merged
brianjaustin merged 1 commit intootwcode:masterfrom Oct 11, 2025
Yanpei-Wang:master
Merged
AO3-7124 Fix chapter numbering in PDF downloads for chapters with custom titles#5387brianjaustin merged 1 commit intootwcode:masterfrom Yanpei-Wang:master
brianjaustin merged 1 commit intootwcode:masterfrom
Yanpei-Wang:master
Conversation
Contributor
Author
|
Supersedes #5377. Had a little branch mix-up before, so here's a clean PR with everything included. |
Bilka2
approved these changes
Oct 3, 2025
Contributor
Bilka2
left a comment
Bilka2
left a comment
There was a problem hiding this comment.
Thank you! I'm approving this because it's fine to merge as is, but if you want it would be nice to fix the indentation.
Cubostar
pushed a commit
to Cubostar/otwarchive
that referenced
this pull request
Oct 14, 2025
…tom titles (otwcode#5387) AO3-7124 fix pdf chapter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-7124
Purpose
This PR fixes the issue where chapter titles in PDF downloads do not include the chapter number if the chapter has a custom title. Now, PDF downloads will match the site’s display of chapter titles.
Credit
Yanpei Wang