Skip to content

Conversation

@parkingTurkeys
Copy link

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-7197

Purpose

This edits the check_user_status before_action filter in the WorksController so that banned or suspended users can access the draft page.

Credit

parking_turkeys, he/they

@Bilka2
Copy link
Contributor

Bilka2 commented Nov 16, 2025

Hi!

Thank you so much for this pull request. Someone will be along to review it soon.

I've updated the Jira issue status to In Review so no one will mistakenly create a duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME)."

Once you've done that (or if you've already done it -- Jira has been unreliable about showing us new accounts in the admin panel lately), you can either reply here or send an email to otw-coders@transformativeworks.org with your account name and email address and we'll set up the permissions for you.

Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above.

Copy link
Contributor

@Bilka2 Bilka2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a rspec test that checks that a suspended or banned user can indeed access the page. The test should be in spec/controllers/works/drafts_spec.rb and you may find the tests added in #4552 useful as examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants