AO3-7250 Remove Cancelled and Invalid Tag Edits From Activities Log#5665
Open
caitlinkwan wants to merge 1 commit intootwcode:masterfrom
Open
Conversation
Contributor
|
ohh yeah, its actually doing some of the things that i was supposed to do and have been procrastinating on... i guess i'll try to actually fix mine soon and see what exactly the overlap ends up being then |
Contributor
Author
I took a glance at your PR and it should just be the implementation + test for the Preview > Cancel situation that overlaps. My proposed solution is changing the callback logic so that the activity only logs after a successful save. If you have questions about anything, feel free to let me know :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7250
Purpose
Restricts admin activities to being created only after checking if the edit is both:
References
Admittedly, only after putting together these fixes did I realize that they overlap with work in review here: AO3-6779. I'm happy to work with @slavalamp to come to a resolution together if necessary!
Credit
caitlin (she/her)