AO3-7356 Reduce N+1 queries on series show page#5668
Merged
Conversation
github-actions
Bot
added
Scope: Tests Only
Bilka2
commented
Mar 25, 2026
| else | ||
| @page_title = get_page_title(@series.fandoms.pluck(:name).join(t("support.array.words_connector")), | ||
| @series.anonymous? ? t(".anonymous") : @series.allpseuds.collect(&:byline).join(t("support.array.words_connector")), | ||
| helpers.text_byline(@series), |
Contributor
Author
There was a problem hiding this comment.
This somewhat changes the format, as previously the browser title only grabbed pseuds from the works, but the byline also grabs them from the series itself. But now it matches the list of creators on the actual page, which I think is better. And this code is cached and also more efficient, so it feels like a very obvious solution
Bilka2
removed
the
Scope: Tests Only
redsummernight
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-7356
Purpose
Remove N+1 queries related to pseuds and users on the series show page. There are still N+1 queries for chapters, but I couldn't figure out how to remove those (refer to code comment). And this already helps a lot.
Failing test pushed first to show it's testing the right thing.
Credit
Bilka