Skip to content

AO3-6857 Improve prompt meme anon tickbox behavior#5779

Open
techlingyi wants to merge 4 commits intootwcode:masterfrom
techlingyi:AO3-6857-prompt-meme-anon-tickbox
Open

AO3-6857 Improve prompt meme anon tickbox behavior#5779
techlingyi wants to merge 4 commits intootwcode:masterfrom
techlingyi:AO3-6857-prompt-meme-anon-tickbox

Conversation

@techlingyi
Copy link
Copy Markdown
Contributor

@techlingyi techlingyi commented May 3, 2026

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6857

Purpose

Previously, for a prompt meme with default-anonymous prompts, all your previously added prompts would default back to a checked anonymous tickbox when you edited your signup, even if you unchecked the tickbox when first creating them. This PR makes it so previously added prompts have their original anonymity status preserved.

Testing Instructions

Anonymous by Default:

  1. Create or find a Prompt Meme with "Prompts Anonymous by Default" checked (https://test.archiveofourown.org/collections/testing_assignments_edited is available on Staging)
  2. Create a prompt sign-up - deselect "Semi-anonymous prompt?", which should be selected by default - and save
  3. Press "Edit Sign-up"
  4. Verify that the first prompt still has the "Semi-anonymous prompt?" unchecked
  5. Add another prompt, this time leaving "Semi-anonymous prompt?" still selected, and save
  6. Press "Edit Sign-up"
  7. Verify the first prompt's tickbox is unchecked and the second prompt's tickbox is checked
  8. Add a third prompt and deselect "Semi-anonymous prompt?", and enter some noncanonical tag before saving
  9. The prompt form should error out
  10. Verify that the first prompt's tickbox is still unchecked, the second is still checked, and the third is also checked (unfortunately) (a sacrifice for the sake of not overcomplicating it)

Not Anonymous by Default:

  1. Create or find a Prompt Meme with "Prompts Anonymous by Default" not checked
  2. Create a prompt sign-up - leave "Semi-anonymous prompt?" unchecked, which it should be by default - and save
  3. Press "Edit Sign-up"
  4. Verify that the first prompt still has the "Semi-anonymous prompt?" unchecked
  5. Add another prompt, this time selecting "Semi-anonymous prompt?", and save
  6. Press "Edit Sign-up"
  7. Verify the first prompt's tickbox is unchecked and the second prompt's tickbox is checked
  8. Add a third prompt and select "Semi-anonymous prompt?", and enter some noncanonical tag before saving
  9. The prompt form should error out
  10. Verify that the first prompt's tickbox is still unchecked, the second is still checked, and the third is also checked (yay!)

References

Undoing some stuff from https://otwarchive.atlassian.net/browse/AO3-2614, corresponding to some of the most recent commits on the prompt form view

Credit

Ling-Yi (any pronouns)

@techlingyi techlingyi marked this pull request as ready for review May 3, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant