One rule for author keys: <backend>_key; the wizard writes it - #276
Merged
Conversation
…ot Anthropic by default The key sentence named Anthropic and one file. Claude and Codex are both authors today, each with its own default key file; say so. The install guide's Level 1 line had the same assumption.
…s what a Codex author needs Listing the Codex key file beside Claude's implied Codex works key-only, but a Codex author also needs the container image and a Codex model. The quick start now names the default and points elsewhere for the rest; the install guide gains the sentence that was missing.
The Claude author's key lived in harness_key with OUTERLOOP_HARNESS_KEY_FILE, a name from when Claude was the only author, beside Codex's codex_key. Now both follow one rule: ~/.config/outerloop/<backend>_key and OUTERLOOP_<BACKEND>_KEY_FILE. The old spellings are still read (new wins when both exist), so a machine set up before the rename keeps working untouched; the exported allowlist carries the new name in both copies. outerloop init asks for the author's model key (hidden paste) and writes <backend>_key 0600, or takes --author-key-file for an existing file, and the .env records the path. The focused --github-app run still asks nothing about the author. That removes the one manual step the quick start had left: three commands and one file, the same for every backend. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Round 1 — reviewed head b6d98a83 — reviewer summarizer:hermes/gpt-5.6-terra over coverage+credentials+deployment+general+lifecycle+prose.
terra
Advisory findings from autoresearch — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.
Verdict: 2 blocking, 2 advisory.
3 findings attached to the lines below.
Advisory (non-blocking):
- Suggestion: Document the legacy config-directory location for generated keys. [prose]
initusesCONFIG_DIRfrompaths.py, which selects ~/.config/autoresearch when that existing directory is present, so the new key is written there rather than to the documented ~/.config/outerloop path. (CHANGELOG.md:92; high confidence)
Verdict: request changes. Two blocking defects affect author-key handling: non-atomic permission tightening exposes newly pasted secrets, and relative key paths are resolved after dispatched climbs enter flight directories. Init should also reject unreadable or missing key files early, and the changelog should reflect legacy CONFIG_DIR selection. Deduplicated: the credentials and coverage opinions are merged because both identify the same creation-time permission race at init.py:91. Rejected: none.
…d stored absolute paths.write_private opens the file with mode 0600 and forces the mode on a pre-existing file before writing, so a pasted key, the PAT, the App PEM and JSON, and .env never exist wider than the owner for any window; init and appmanifest use it everywhere they wrote a secret and then chmod'd it. A --author-key-file must be a readable file (a typo fails init, not the first climb) and is stored absolute, since climb jobs read it from their own flight directory. The changelog says which config dir the key lands in on a machine set up before the rename. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes that together remove the last hand-edited step from setup.
One rule for author key files. The Claude author read
~/.config/outerloop/harness_keyviaOUTERLOOP_HARNESS_KEY_FILE, a name from when Claude was the only author, beside Codex'scodex_key. Now every backend follows~/.config/outerloop/<backend>_keyandOUTERLOOP_<BACKEND>_KEY_FILE. Read-both, write-new like the other renames: the legacy env var and file are still honored, the new name wins when both exist, so the Torch fleet keeps working untouched.AUTORESEARCH_CLAUDE_KEY_FILEis added to the exported allowlist in bothcli.pyandtick_deploy.sh(the parity test covers the pair).The wizard writes the key.
outerloop initasks for the author's model API key with a hidden prompt and writes<backend>_key(0600), or takes--author-key-filefor an existing file; the.envrecordsOUTERLOOP_<BACKEND>_KEY_FILE. Asked after the overwrite check, so a declined run never asks for a secret; never asked on the focused--github-apprun. A blank answer leaves a hint naming the file.Docs. The README quick start is three commands and one file with no key sentence and no backend named; the install guide and the onboarding design note use the new names. Changelog under Unreleased. Supersedes #275 (its wording is included here).
Verified: ruff, ruff format, mypy (clean cache), 1220 tests, pre-commit.
🤖 Generated with Claude Code