Skip to content

CONTRIBUTING.md for people outside the lab - #279

Merged
renmengye merged 3 commits into
mainfrom
docs/contributing-public
Sep 6, 2026
Merged

CONTRIBUTING.md for people outside the lab#279
renmengye merged 3 commits into
mainfrom
docs/contributing-public

Conversation

@renmengye

Copy link
Copy Markdown
Contributor

The current CONTRIBUTING.md reads as a lab-internal process note: dated PI rules, the solo-phase branch-protection setting, a long essay on review-round termination, and from autoresearch... imports. Public contributors need a different document.

Rewritten around what a first-time contributor needs, in order: before you start (issues first for big changes, security goes to SECURITY.md), setup, making a change with the exact gate CI runs, what happens to the PR (CI, the agent reviewer posts findings and never blocks, a maintainer re-labels for another round and merges with a merge commit), conventions, the test tiers table, a short note on what bot-authored PRs are and where they live, and the license.

The review-until-quiet mechanics are the maintainers' working rule, not a contributor requirement; they belong in the reviewer design notes rather than here.

🤖 Generated with Claude Code

renmengye and others added 2 commits September 5, 2026 20:12
The old text was a lab-internal process note: dated PI rules, the solo-phase
protection setting, an essay on adversarial review rounds, and imports from
the pre-rename package. Rewritten for a public contributor: what to do
before starting, setup, the gate to run before pushing, what happens to a PR
(CI, the agent reviewer's findings, a maintainer merging with a merge
commit), conventions, the test tiers, what bot PRs are, and the license.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 1 — reviewed head fcca8a7e — reviewer summarizer:hermes/gpt-5.6-terra over coverage+credentials+deployment+general+lifecycle+prose.

terra
Advisory findings from autoresearch — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.

Verdict: nothing blocking — 6 advisory notes.

6 findings attached to the lines below.

Verdict: six documentation findings, none merge-blocking. The guide’s claimed CI-equivalent local gate omits uv lock --check and full-history gitleaks; it overpromises agent-review coverage for forks and a “few minutes” turnaround; it gives an unusable re-review instruction unless the existing label is removed first; and it incorrectly says all bot PRs require review despite documented/supported auto-merge cases. It also uses unexplained “kernel itself” jargon. Rejected findings: none; all supplied findings were either merged with corroborating lenses or retained as the required prose suggestion.

Comment thread CONTRIBUTING.md
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
… mechanics, auto-merge targets, no timing promise, no jargon
@renmengye
renmengye merged commit 53f0a36 into main Sep 6, 2026
1 check passed
@renmengye
renmengye deleted the docs/contributing-public branch September 6, 2026 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant