ci: fix test identity and align MSRV - #9
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 15a595bfd5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| env: | ||
| GIT_AUTHOR_NAME: Batch Git Tests | ||
| GIT_AUTHOR_EMAIL: batch-git@example.invalid | ||
| GIT_COMMITTER_NAME: Batch Git Tests | ||
| GIT_COMMITTER_EMAIL: batch-git@example.invalid |
There was a problem hiding this comment.
Scope test Git identity to fixture repositories
Because this env block is workflow-wide, every black-box batch-git invocation and its Git children inherit these values. Git documents the author and committer environment variables as overriding repository identity configuration (Git environment variables); consequently, tests that call configure_identity with a repository-specific name actually commit as Batch Git Tests. CI therefore no longer exercises the documented behavior of preserving each repository's identity and could pass an identity-routing regression. Configure identity in the merge and passthrough fixture repositories that require it, or remove these variables from tested product processes.
Useful? React with 👍 / 👎.
Summary
Root causes
The blocked Dependabot PRs exposed two independent baseline failures on
main:Committer identity unknownValidation
cargo +1.88.0 test --lockedcargo fmt -- --checkcargo test --lockedcargo test --locked --no-default-featurescargo clippy --all-targets --all-features -- -D warningscargo build --locked --release