Skip to content

ci: fix test identity and align MSRV - #9

Merged
ovaso merged 2 commits into
mainfrom
codex/fix-ci-git-identity
Aug 6, 2026
Merged

ci: fix test identity and align MSRV#9
ovaso merged 2 commits into
mainfrom
codex/fix-ci-git-identity

Conversation

@ovaso

@ovaso ovaso commented Aug 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • configure deterministic Git author and committer identities for GitHub Actions
  • unblock integration tests that create commits and merges on clean runners
  • correct the declared and CI-tested MSRV from Rust 1.85 to Rust 1.88, matching the language features used by the current source
  • synchronize the English and Simplified Chinese compatibility docs, user guides, and changelogs

Root causes

The blocked Dependabot PRs exposed two independent baseline failures on main:

  1. integration tests inherited no Git identity on GitHub-hosted runners and failed with Committer identity unknown
  2. the source uses stabilized let chains, so it cannot compile on the previously declared Rust 1.85 toolchain

Validation

  • cargo +1.88.0 test --locked
  • cargo fmt -- --check
  • cargo test --locked
  • cargo test --locked --no-default-features
  • cargo clippy --all-targets --all-features -- -D warnings
  • cargo build --locked --release

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 15a595bfd5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yml
Comment on lines +12 to +16
env:
GIT_AUTHOR_NAME: Batch Git Tests
GIT_AUTHOR_EMAIL: batch-git@example.invalid
GIT_COMMITTER_NAME: Batch Git Tests
GIT_COMMITTER_EMAIL: batch-git@example.invalid

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Scope test Git identity to fixture repositories

Because this env block is workflow-wide, every black-box batch-git invocation and its Git children inherit these values. Git documents the author and committer environment variables as overriding repository identity configuration (Git environment variables); consequently, tests that call configure_identity with a repository-specific name actually commit as Batch Git Tests. CI therefore no longer exercises the documented behavior of preserving each repository's identity and could pass an identity-routing regression. Configure identity in the merge and passthrough fixture repositories that require it, or remove these variables from tested product processes.

Useful? React with 👍 / 👎.

@ovaso ovaso changed the title ci: configure git identity for tests ci: fix test identity and align MSRV Aug 6, 2026
@ovaso
ovaso merged commit 5d5c4e6 into main Aug 6, 2026
13 of 14 checks passed

@ovaso ovaso left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant