test: drop NodeHTTPResponse.rs from the dead-code escape inventory - #37994
Conversation
#37977 removed the allow but left the inventory at 1, so the source-lints job fails on main. No-Verification-Needed: lint inventory only
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThe pull request removes the ChangesDead-code configuration
Mergeability Score: ⚪ Minimal · up to This localized test-inventory update removes an obsolete entry and presents no actionable merge-blocking risk beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
There was a problem hiding this comment.
LGTM — mechanical inventory sync.
What was reviewed:
- Verified
src/runtime/server/NodeHTTPResponse.rshas zero#[allow(dead_code)]occurrences, so dropping the entry is correct. - Confirmed the remaining JSON is well-formed and no adjacent entries were disturbed.
Extended reasoning...
Overview
Single-line deletion from test/internal/source-lints/dead-code-escape-limits.json, removing the src/runtime/server/NodeHTTPResponse.rs: 1 entry. This file is a generated inventory that caps how many #[allow(dead_code)] escapes each source file may contain; the source-lints test fails when the inventory drifts from reality in either direction. #37977 removed the last such attribute from NodeHTTPResponse.rs without regenerating the inventory, so the lint job has been red on main.
Security risks
None. This is test-only lint metadata with no runtime, build, or dependency impact.
Level of scrutiny
Minimal. The change is mechanical and self-verifying: I grepped src/runtime/server/NodeHTTPResponse.rs for allow(dead_code) and found zero matches, which is exactly what a removed entry (implicit limit 0) encodes. The PR description states it was regenerated via the test's own snapshot mechanism, and the resulting JSON is syntactically valid with surrounding entries untouched.
Other factors
No prior reviewer comments to address, no CODEOWNERS on this path, and the bug-hunting pass found nothing. This is the canonical fix for a stale generated-inventory failure and carries no design or behavioral surface.
#37977 removed the last #[allow(dead_code)] in NodeHTTPResponse.rs but left the inventory at 1, so the source-lints job has been failing on main since a28fcc4. Regenerated with bun ./test/internal/source-lints/dead-code-escapes.test.ts.