Skip to content

test: drop NodeHTTPResponse.rs from the dead-code escape inventory - #37994

Merged
alii merged 1 commit into
mainfrom
ali/dead-code-escape-inventory
Aug 13, 2026
Merged

test: drop NodeHTTPResponse.rs from the dead-code escape inventory#37994
alii merged 1 commit into
mainfrom
ali/dead-code-escape-inventory

Conversation

@alii

@alii alii commented Aug 13, 2026

Copy link
Copy Markdown
Member

#37977 removed the last #[allow(dead_code)] in NodeHTTPResponse.rs but left the inventory at 1, so the source-lints job has been failing on main since a28fcc4. Regenerated with bun ./test/internal/source-lints/dead-code-escapes.test.ts.

#37977 removed the allow but left the inventory at 1, so the source-lints job fails on main.

No-Verification-Needed: lint inventory only
@robobun

robobun commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator
Updated 9:05 PM PT - Aug 12th, 2026

@alii, your commit 756ae4a is building: #93893

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9bbbc159-a97c-4e33-be3b-2eb7fb71088d

📥 Commits

Reviewing files that changed from the base of the PR and between 94898e0 and 756ae4a.

📒 Files selected for processing (1)
  • test/internal/source-lints/dead-code-escape-limits.json
💤 Files with no reviewable changes (1)
  • test/internal/source-lints/dead-code-escape-limits.json

Walkthrough

The pull request removes the NodeHTTPResponse.rs entry from the dead-code escape limits configuration.

Changes

Dead-code configuration

Layer / File(s) Summary
Remove obsolete escape limit
test/internal/source-lints/dead-code-escape-limits.json
The configuration no longer includes a dead-code escape limit for src/runtime/server/NodeHTTPResponse.rs.

Mergeability Score: ⚪ Minimal · up to 756ae

This localized test-inventory update removes an obsolete entry and presents no actionable merge-blocking risk beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the removal of NodeHTTPResponse.rs from the dead-code escape inventory.
Description check ✅ Passed The description explains the stale inventory entry, the related change, and the regeneration command used for verification.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — mechanical inventory sync.

What was reviewed:

  • Verified src/runtime/server/NodeHTTPResponse.rs has zero #[allow(dead_code)] occurrences, so dropping the entry is correct.
  • Confirmed the remaining JSON is well-formed and no adjacent entries were disturbed.
Extended reasoning...

Overview

Single-line deletion from test/internal/source-lints/dead-code-escape-limits.json, removing the src/runtime/server/NodeHTTPResponse.rs: 1 entry. This file is a generated inventory that caps how many #[allow(dead_code)] escapes each source file may contain; the source-lints test fails when the inventory drifts from reality in either direction. #37977 removed the last such attribute from NodeHTTPResponse.rs without regenerating the inventory, so the lint job has been red on main.

Security risks

None. This is test-only lint metadata with no runtime, build, or dependency impact.

Level of scrutiny

Minimal. The change is mechanical and self-verifying: I grepped src/runtime/server/NodeHTTPResponse.rs for allow(dead_code) and found zero matches, which is exactly what a removed entry (implicit limit 0) encodes. The PR description states it was regenerated via the test's own snapshot mechanism, and the resulting JSON is syntactically valid with surrounding entries untouched.

Other factors

No prior reviewer comments to address, no CODEOWNERS on this path, and the bug-hunting pass found nothing. This is the canonical fix for a stale generated-inventory failure and carries no design or behavioral surface.

@alii
alii merged commit e27343a into main Aug 13, 2026
8 checks passed
@alii
alii deleted the ali/dead-code-escape-inventory branch August 13, 2026 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants