(feat) allow the saving of multiple tokens #705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tphoney
force-pushed
the
improve_token_file
branch
from
9af045b to
1712631
Compare
tphoney
force-pushed
the
improve_token_file
branch
from
1712631 to
79ec2af
Compare
dylanratcliffe
requested changes
Dec 4, 2024
Member
dylanratcliffe
left a comment
dylanratcliffe
left a comment
There was a problem hiding this comment.
Just asking for changes around the "error" message. Having the tests are great
tphoney
force-pushed
the
improve_token_file
branch
from
fff8546 to
ee7bef6
Compare
Member
Author
Using a local token, and what app is being used
Bad token example
Notifying a user we have saved a token, after auth
|
tphoney
force-pushed
the
improve_token_file
branch
2 times, most recently
from
699adf9 to
4348a01
Compare
Member
|
@tphoney What does it look like when there is no token file at all? |
Member
Author
no token file exists
|
Member
|
@tphoney Would you mind suppressing that particular error? I don't think it adds any value and I don't want to muddy the first experience, the rest is very good |
tphoney
force-pushed
the
improve_token_file
branch
from
4348a01 to
7e3f9e6
Compare
tphoney
force-pushed
the
improve_token_file
branch
from
7e3f9e6 to
4edeb60
Compare
Member
Author
|
@dylanratcliffe @DavidS-ovm os.stat for a missing token file is now ignored. |
dylanratcliffe
approved these changes
Dec 4, 2024
DavidS-ovm
approved these changes
Dec 5, 2024
| if app == "" { | ||
| log.Fatal("no app specified, please use --app or set OVM_APP") | ||
| } | ||
| viper.Set("app", app) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re #687