Use keys for plugin manifest tabs and admin pages - #9
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the SDK templates, examples, and documentation to reflect the new keyed manifest shape for viewer tabs (manifest.tabs) and admin pages (manifest.admin.pages), replacing the legacy array-of-objects form.
Changes:
- Updated JS/Python
create-owncast-pluginskills to documenttabsandadmin.pagesas identifier-keyed objects. - Migrated example manifests and example docs (READMEs/INSTRUCTIONS) to the keyed
tabs/ keyedadmin.pagesformat. - Updated protocol/author documentation to describe keyed shapes and ordering expectations.
Reviewed changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdks/python/owncast_plugin/template/.agents/skills/create-owncast-plugin-py/SKILL.md | Updates manifest shape notes for keyed tabs and keyed admin.pages. |
| sdks/js/create-owncast-plugin/template/.agents/skills/create-owncast-plugin-js/SKILL.md | Updates manifest shape notes for keyed tabs and keyed admin.pages. |
| rules-tab/plugin.manifest.json | Converts tabs and admin.pages to keyed-object form. |
| examples/python/theme-hub/plugin.manifest.json | Converts admin.pages to keyed-object form. |
| examples/python/tabs-demo/README.md | Updates documentation and JSON snippet for keyed tabs. |
| examples/python/tabs-demo/plugin.manifest.json | Converts tabs to keyed-object form. |
| examples/python/tabs-demo/INSTRUCTIONS.md | Updates explanation text for keyed tabs and emitted tab keys. |
| examples/python/README.md | Updates reference from manifest.tabs[] to manifest.tabs. |
| examples/python/page-content-demo/README.md | Updates JSON snippet for keyed tabs. |
| examples/python/page-content-demo/plugin.manifest.json | Converts tabs to keyed-object form. |
| examples/python/page-content-demo/INSTRUCTIONS.md | Updates JSON snippet for keyed tabs. |
| examples/python/manual-video-settings/README.md | Updates JSON snippet for keyed admin.pages. |
| examples/python/manual-video-settings/plugin.manifest.json | Converts admin.pages to keyed-object form. |
| examples/python/file-manager/plugin.manifest.json | Converts admin.pages to keyed-object form. |
| examples/python/admin-demo/plugin.manifest.json | Converts admin.pages to keyed-object form (multiple pages). |
| examples/python/action-buttons/plugin.manifest.json | Converts admin.pages to keyed-object form. |
| examples/js/theme-hub/plugin.manifest.json | Converts admin.pages to keyed-object form. |
| examples/js/tabs-demo/README.md | Updates documentation and JSON snippet for keyed tabs. |
| examples/js/tabs-demo/plugin.manifest.json | Converts tabs to keyed-object form. |
| examples/js/tabs-demo/INSTRUCTIONS.md | Updates explanation text for keyed tabs and emitted tab keys. |
| examples/js/rules-tab/plugin.manifest.json | Converts tabs and admin.pages to keyed-object form. |
| examples/js/README.md | Updates reference from manifest.tabs[] to manifest.tabs. |
| examples/js/page-content-demo/README.md | Updates JSON snippet for keyed tabs. |
| examples/js/page-content-demo/plugin.manifest.json | Converts tabs to keyed-object form. |
| examples/js/page-content-demo/INSTRUCTIONS.md | Updates JSON snippet for keyed tabs. |
| examples/js/manual-video-settings/README.md | Updates JSON snippet for keyed admin.pages. |
| examples/js/manual-video-settings/plugin.manifest.json | Converts admin.pages to keyed-object form. |
| examples/js/file-manager/plugin.manifest.json | Converts admin.pages to keyed-object form. |
| examples/js/admin-demo/plugin.manifest.json | Converts admin.pages to keyed-object form (multiple pages). |
| examples/js/action-buttons/plugin.manifest.json | Converts admin.pages to keyed-object form. |
| docs/WIRE_PROTOCOL.md | Updates protocol docs for keyed tabs / keyed admin.pages and related permission notes. |
| docs/PLUGIN_AUTHOR_GUIDE.md | Updates author guidance/examples for keyed tabs / keyed admin.pages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gabek
force-pushed
the
gek/plugin-manifest-maps
branch
from
August 2, 2026 03:28
19aacfd to
c76ce6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes plugin manifest tabs and admin pages from arrays with repeated identifiers to objects keyed by those identifiers.
tabsby tab slug andadmin.pagesby plugin-relative pathslugandpathmembers and duplicate keysI ran the core Go tests and web production build. The keyed manifest examples and admin page flow were also exercised through the plugin scenario and browser checks.
This branch is based on the SQL SDK change already on the stack where required. It does not change unrelated plugin behavior.
Fixes owncast/owncast#5087