Specify database-connection-string when installing with Oracle#79
Merged
Conversation
Contributor
Author
|
@jnweiger did something change in the last few days/week in the way that the oC10 core tarball is created? |
Contributor
Author
|
Merging so that we can see the difference in nightly CI tonight. |
|
That is strange. First time I hear about database-connection-string. No intended changes from my side, except that we have more bundled apps since 10.13 |
This was referenced Aug 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of issue https://github.com/owncloud/files_classifier/issues/786
oC10 core PR owncloud/core#36489 added
database-connection-stringfor use when installing oC10 with Oracle DB. That PR added the logic to core drone CI to use that:https://github.com/owncloud/core/pull/36489/files#diff-f42ddc060d71e10c4670605d3d4cd43b0053576cf67e7f1c87cc373779130094
But it was not added here in
owncloud-ci/coreFor some reason, oC10 core master with the daily tarball needs
database-connection-stringto be specified. Without that, the install gets the error documented in the attached issue.So far, I don't know what changed in the daily tarball to cause this - but we might as well put this matching install code here, and dig into the underlying reason in the next day or so.