Bring back storagePath argument in startLogging#91
Conversation
|
@przybylski Welcome back! 😉 Can I ask you to fix the breaking unit test? THX |
|
Yeeeha! :D @davivel @masensio @tobiasKaminsky @AndyScherzinger check it out – @przybylski is back, the person who wrote the original ownCloud Android app. :) |
|
@DeepDiver1975 @jancborchardt Hi! :) Good to be back. Anyways, I tried to run them on localhost and got server_base_url is null error. Is there some sort of global (resource) which I need to fix in order to get that working ? BTW the same thing is happening on travis: |
|
after chatting with @davivel - failing travis is related to the secrets which are used - travis will fail on forks my nature. @przybylski you still have push access I assume - please open this PR from a non-fork-branch - THX |
|
@DeepDiver1975 I no longer have push access |
hmmm ... but you dd sign the contrib agreement back in the old days - right? |
|
AFAIR I did |
|
@karlitschek can we readd @przybylski ? THX |
|
Yeah! Welcome back @przybylski ! :) |
|
Any progress on this? |
|
@przybylski Also on this PR. It is much easier for all if the PRs are in the repository and writeable by all. |
|
@przybylski as with every pull request it’s good to cross-review – everyone should also go through pull requests of other people and review them. :) Then we are much faster. |
|
I know :) |
This is a part of owncloud/android#10 which i'm currently working on