Skip to content
This repository was archived by the owner on Mar 19, 2024. It is now read-only.

Bring back storagePath argument in startLogging#91

Closed
przybylski wants to merge 5 commits into
owncloud:masterfrom
przybylski:master
Closed

Bring back storagePath argument in startLogging#91
przybylski wants to merge 5 commits into
owncloud:masterfrom
przybylski:master

Conversation

@przybylski

Copy link
Copy Markdown
Contributor

This is a part of owncloud/android#10 which i'm currently working on

@DeepDiver1975

Copy link
Copy Markdown
Member

@przybylski Welcome back! 😉 Can I ask you to fix the breaking unit test? THX

@jancborchardt

Copy link
Copy Markdown

Yeeeha! :D @davivel @masensio @tobiasKaminsky @AndyScherzinger check it out – @przybylski is back, the person who wrote the original ownCloud Android app. :)

@przybylski

Copy link
Copy Markdown
Contributor Author

@DeepDiver1975 @jancborchardt Hi! :) Good to be back.

Anyways, I tried to run them on localhost and got server_base_url is null error. Is there some sort of global (resource) which I need to fix in order to get that working ?

BTW the same thing is happening on travis:
Caused by: java.lang.IllegalArgumentException: host parameter is null

@DeepDiver1975

Copy link
Copy Markdown
Member

after chatting with @davivel - failing travis is related to the secrets which are used - travis will fail on forks my nature.

@przybylski you still have push access I assume - please open this PR from a non-fork-branch - THX

@przybylski

Copy link
Copy Markdown
Contributor Author

@DeepDiver1975 I no longer have push access

@DeepDiver1975

Copy link
Copy Markdown
Member

@DeepDiver1975 I no longer have push access

hmmm ... but you dd sign the contrib agreement back in the old days - right?

@przybylski

Copy link
Copy Markdown
Contributor Author

AFAIR I did

@DeepDiver1975

Copy link
Copy Markdown
Member

@karlitschek can we readd @przybylski ? THX

@AndyScherzinger

Copy link
Copy Markdown
Contributor

Yeah! Welcome back @przybylski ! :)

@przybylski

Copy link
Copy Markdown
Contributor Author

Any progress on this?

@tobiasKaminsky

Copy link
Copy Markdown

@przybylski Also on this PR. It is much easier for all if the PRs are in the repository and writeable by all.
(regarding your question on update: have a look an some other PRs and see how long they are open... They need some time...)

@jancborchardt

Copy link
Copy Markdown

@przybylski as with every pull request it’s good to cross-review – everyone should also go through pull requests of other people and review them. :) Then we are much faster.

@przybylski

Copy link
Copy Markdown
Contributor Author

I know :)
This pull request was closed because i did open new one from repository branch

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants