Skip to content

External sd - allow users to specify storage path#1285

Closed
przybylski wants to merge 8 commits into
owncloud:masterfrom
przybylski:externalSD2
Closed

External sd - allow users to specify storage path#1285
przybylski wants to merge 8 commits into
owncloud:masterfrom
przybylski:externalSD2

Conversation

@przybylski

Copy link
Copy Markdown
Contributor

This is a new pull as recommended by @tobiasKaminsky in #1276

This pull requires this owncloud/android-library#91 pull from library to work.

@tobiasKaminsky tobiasKaminsky mentioned this pull request Nov 18, 2015
@tobiasKaminsky

Copy link
Copy Markdown
Contributor

Ah. I think I was not clear enough.
My idea was that you create a branch in this repository with the changes and then open a PR from owncloud:externalSD to owncloud:master.
For instance see: #1240.
With this is it possible that all devs (that have read/write access to this repository) can update the branch if necessary.
(Also it is much more easier to merge these changes to beta version)

After that I am happy to include your feature to beta version (and will also take care of the library)

@przybylski

Copy link
Copy Markdown
Contributor Author

AFAIK I don't have write permission to owncloud-android so I cannot create branches or commit to owncloud/android. Or maybe I am mistaken?

@tobiasKaminsky

Copy link
Copy Markdown
Contributor

Just try it :)
If you have signed the agreement you should have write access.
CC @davivel

@tobiasKaminsky

Copy link
Copy Markdown
Contributor

Ah. I see that you are not marked with "Collaborator".
This can then be a problem...
Waiting what @davivel says

@AndyScherzinger

Copy link
Copy Markdown
Contributor

Pinging @masensio for the repo permission issue of @przybylski :)

@przybylski przybylski closed this Nov 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants