Skip to content

Whats new #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davigonz merged 30 commits into from
Mar 12, 2018
Merged

Whats new #1375

davigonz merged 30 commits into from
Mar 12, 2018

Conversation

@przybylski
Copy link
Member

@przybylski przybylski commented Dec 21, 2015

TODO:

  • add graphics for initial start
  • adjust graphics to designer notes

BUG:

  • Whats new is showing twice on first install

@przybylski przybylski force-pushed the whatsNew branch 2 times, most recently from d9cb8cc to 3416f56 Compare December 21, 2015 20:20
@tobiasKaminsky
Copy link
Contributor

tobiasKaminsky commented Dec 21, 2015

BuildConfig is only available on gradle and not on ant building system :/

@przybylski
Copy link
Member Author

przybylski commented Dec 21, 2015

yeah I know that, just pushed fix ;)
but i don't like it too much

@przybylski
Copy link
Member Author

przybylski commented Feb 13, 2016

Finally, it's done. It took me more time then I wanted to but...

@AndyScherzinger AndyScherzinger mentioned this pull request Jun 20, 2016
Closed
@przybylski przybylski mentioned this pull request Jun 21, 2016
Closed
@jancborchardt jancborchardt mentioned this pull request Jun 27, 2016
Closed
@AndyScherzinger AndyScherzinger mentioned this pull request Jan 15, 2018
Closed
@jesmrec jesmrec added this to the 2.7.0 milestone Jan 16, 2018
@davigonz
Copy link
Contributor

davigonz commented Feb 6, 2018

Hi @przybylski , thanks for this contribution, we are going to resume the work here, let's start with a rebase

@davigonz davigonz self-assigned this Feb 6, 2018
@davigonz davigonz force-pushed the whatsNew branch 4 times, most recently from 8ae0744 to 725ccdd Compare February 15, 2018 12:05
@davigonz davigonz force-pushed the whatsNew branch 2 times, most recently from d8824ca to d3d2273 Compare February 21, 2018 11:33
@davigonz
Copy link
Contributor

davigonz commented Feb 21, 2018

@jesmrec this is ready to test

@davigonz davigonz requested a review from jesmrec March 2, 2018 11:51
@davigonz davigonz requested a review from theScrabi March 6, 2018 10:16
@jesmrec jesmrec mentioned this pull request Mar 6, 2018
Closed
przybylski and others added 22 commits March 12, 2018 09:19
@przybylski @davigonz
Use global method to get version code
034bf84
@AndyScherzinger @davigonz
added iOS images for the whats new screens
8e50b26
@AndyScherzinger @davigonz
changes indicator to more material like style
28bf623
@AndyScherzinger @davigonz
small design changes, adding arrow as vector (thus bumping gradle plu…
f4f821e 
…gin to 1.5.0!), changing check icon and adding circle background for finish action
@przybylski @davigonz
Till java7 won't be used on ant project use old diamond notation
d007742
@AndyScherzinger @davigonz
rework icons to not break ANT builds
373403a
@AndyScherzinger @davigonz
use the standard dp margin & padding references
7c5390a
@davigonz
Add parameter to allow showing whats new in beta
15fde38
@davigonz
Use ViewPager instead of custom dragging mechanism
1a860a1
@davigonz
Change the way of displaying progress indicator
d3087e3
@davigonz
Show whats new only once on first run
6a4ebd6
@davigonz
tabs to spaces
2949fee
@davigonz
tabs to spaces
65b9b43
@davigonz
Update wizard colors and resources
f490d8a
@davigonz
Change features order and texts color
1e1e777
@davigonz
Step 1, manage all your files resource
11d857c
@davigonz
Step 2, share files and folders resource
55a4b85
@davigonz
Step 3, multi account resources
4a0abda
@davigonz
Step 4, camera uploads resources + update some titles
00a4843
@davigonz
Step 5, video streaming resources
89ff915
@davigonz
Update some dates and minor changes
1b482c3
@davigonz
Include flag to enable or disable the wizard
f0d4bd6
jesmrec
jesmrec approved these changes Mar 12, 2018
View reviewed changes
res/drawable-anydpi-v21/arrow_right.xml
android:width="24dp"
android:viewportWidth="24"
android:viewportHeight="24">
<path android:fillColor="#FFFFFF" android:pathData="M4,11V13H16L10.5,18.5L11.92,19.92L19.84,12L11.92,4.08L10.5,5.5L16,11H4Z" />
Copy link
Collaborator

@jesmrec jesmrec Mar 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it posible to wrap this line?

@jesmrec
Copy link
Collaborator

jesmrec commented Mar 12, 2018

Approved

@davigonz
Copy link
Contributor

davigonz commented Mar 12, 2018

Approved

Awesome, merging then...

@davigonz davigonz merged commit 8404e09 into master Mar 12, 2018
@davigonz davigonz deleted the whatsNew branch March 12, 2018 11:58
@davigonz davigonz removed this from the 2.7.0 milestone Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jesmrec jesmrec jesmrec approved these changes

+1 more reviewer

@theScrabi theScrabi theScrabi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@davigonz davigonz

Labels

Approved by qa

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@przybylski @tobiasKaminsky @davigonz @jesmrec @theScrabi @davivel @AndyScherzinger