Changed from custom file picker implementation to SAF by shashvat-kedia · Pull Request #2479 · owncloud/android

shashvat-kedia · 2019-03-10T16:58:10Z

Fix to issue #2436.

Test plan:

https://github.com/owncloud/QA/blob/master/Mobile/Android/Release_2.11.0/2479-SAF_file_picker.md

QA:

shashvat-kedia · 2019-03-10T16:59:19Z

@jesmrec @davigonz I have changed to SAF implementation and have removed the code corresponding to previous functionality(select all, select-inverse, sorting etc.).

shashvat-kedia · 2019-03-22T05:43:38Z

@jesmrec @abelgardep I have made the changes.

shashvat-kedia · 2019-05-16T07:02:29Z

@abelgardep @jesmrec Are there any more changes required in this? If not then I think this is ready for QA.

davigonz · 2019-05-16T07:11:34Z

-                        UploadFilesActivity.startUploadActivityForResult(getActivity(), ((FileActivity) getActivity())
-                                .getAccount(), FileDisplayActivity.REQUEST_CODE__SELECT_FILES_FROM_FILE_SYSTEM);
+                        Intent action = new Intent(Intent.ACTION_GET_CONTENT);
+                        action = action.setType("*/*").addCategory(Intent.CATEGORY_OPENABLE);


Could you please save */* in a constant?

davigonz · 2019-05-16T07:14:27Z

Are there any more changes required in this? If not then I think this is ready for QA.

Just a minor change and we can move it forward.

shashvat-kedia · 2019-05-16T07:19:49Z

@davigonz I have made the changes.

davigonz · 2019-05-16T07:24:25Z

                    public boolean onTouch(View v, MotionEvent event) {
                        Intent action = new Intent(Intent.ACTION_GET_CONTENT);
-                        action = action.setType("*/*").addCategory(Intent.CATEGORY_OPENABLE);
+                        action = action.setType(getString(R.string.all_files_saf_filter)).addCategory(Intent.CATEGORY_OPENABLE);


I meant a constant at the top of this class, we usually include strings in owncloudApp/src/main/res/values/strings.xml when some translations are needed and this is not the case.

shashvat-kedia · 2019-05-16T07:29:53Z

@davigonz I have reverted the previous change and have done the new one.

davigonz · 2019-05-21T16:20:55Z


    private static String DIALOG_CREATE_FOLDER = "DIALOG_CREATE_FOLDER";

+    private final String ALL_FILES_SAF_REGEX = "*/*";


davigonz · 2019-05-21T16:26:50Z

Code approved @SD1998 , ready to test @jesmrec

jesmrec · 2019-05-22T13:53:47Z

Let's QA this

jesmrec · 2019-05-22T15:22:04Z

Everything correct, more simplified logic and more versatility and integration with the other apps in the device. Approved on my side.

@SD1998 could you rebase the branch to merge?

shashvat-kedia · 2019-05-22T15:31:49Z

@jesmrec Yeah surely.

shashvat-kedia · 2019-05-22T17:36:25Z

@jesmrec I have done the rebase.

jesmrec · 2019-05-23T07:16:15Z

We have merged another PR, so we need here another rebase. Sorry for the inconvenience @SD1998

shashvat-kedia · 2019-05-23T16:55:07Z

@jesmrec Not an issue. I have done the rebase.

jesmrec · 2019-05-24T06:29:35Z

Thanks!!

davigonz assigned shashvat-kedia Mar 11, 2019

davigonz requested a review from abelgardep March 11, 2019 08:16

davigonz added this to the 2.11.0 milestone Mar 11, 2019

abelgardep reviewed Mar 11, 2019

View reviewed changes

Comment thread owncloudApp/src/main/res/layout/list_fragment.xml

abelgardep suggested changes Mar 11, 2019

View reviewed changes

Comment thread owncloudApp/src/main/java/com/owncloud/android/ui/fragment/OCFileListFragment.java Outdated

jesmrec removed this from the 2.11.0 milestone Mar 11, 2019

shashvat-kedia force-pushed the Fix-2436-New branch from e2f8ca5 to 95f628d Compare March 22, 2019 05:46

shashvat-kedia force-pushed the Fix-2436-New branch from 95f628d to 1ee62d0 Compare March 29, 2019 11:44

abelgardep approved these changes May 8, 2019

View reviewed changes

shashvat-kedia force-pushed the Fix-2436-New branch from 1ee62d0 to 1703354 Compare May 15, 2019 14:37

davigonz suggested changes May 16, 2019

View reviewed changes

shashvat-kedia force-pushed the Fix-2436-New branch from 3374184 to 4eafb6c Compare May 16, 2019 07:29

davigonz mentioned this pull request May 21, 2019

Replace the ownCloud file picker with the Android one when uploading files #2436

Closed

davigonz reviewed May 21, 2019

View reviewed changes

davigonz approved these changes May 21, 2019

View reviewed changes

jesmrec self-assigned this May 22, 2019

jesmrec self-requested a review May 22, 2019 15:22

jesmrec approved these changes May 22, 2019

View reviewed changes

jesmrec added the Approved by qa label May 22, 2019

shashvat-kedia force-pushed the Fix-2436-New branch from 4eafb6c to cc7e664 Compare May 22, 2019 17:35

shashvat-kedia added 4 commits May 23, 2019 22:24

Shift to SAF from custom file picker implementation

0f50f41

unused xml files removed

5f7957b

Unused drawables removed and other code review changes

95ea208

String constant added for All files SAF filter

858a7d0

shashvat-kedia force-pushed the Fix-2436-New branch from cc7e664 to 858a7d0 Compare May 23, 2019 16:54

jesmrec merged commit c6e2418 into owncloud:master May 23, 2019

shashvat-kedia deleted the Fix-2436-New branch May 23, 2019 17:33


		private static String DIALOG_CREATE_FOLDER = "DIALOG_CREATE_FOLDER";

		private final String ALL_FILES_SAF_REGEX = "/";

Uh oh!

Conversation

shashvat-kedia commented Mar 10, 2019 • edited by jesmrec Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test plan:

QA:

Uh oh!

shashvat-kedia commented Mar 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shashvat-kedia commented Mar 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shashvat-kedia commented May 16, 2019

Uh oh!

davigonz May 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davigonz commented May 16, 2019

Uh oh!

shashvat-kedia commented May 16, 2019

Uh oh!

davigonz May 16, 2019

Choose a reason for hiding this comment

Uh oh!

shashvat-kedia commented May 16, 2019

Uh oh!

davigonz May 21, 2019

Choose a reason for hiding this comment

Uh oh!

davigonz commented May 21, 2019

Uh oh!

jesmrec commented May 22, 2019

Uh oh!

jesmrec commented May 22, 2019

Uh oh!

shashvat-kedia commented May 22, 2019

Uh oh!

shashvat-kedia commented May 22, 2019

Uh oh!

jesmrec commented May 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shashvat-kedia commented May 23, 2019

Uh oh!

jesmrec commented May 24, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

shashvat-kedia commented Mar 10, 2019 •

edited by jesmrec

Loading

shashvat-kedia commented Mar 10, 2019 •

edited

Loading

shashvat-kedia commented Mar 22, 2019 •

edited

Loading

davigonz May 16, 2019 •

edited

Loading

jesmrec commented May 23, 2019 •

edited

Loading