Skip to content

Fix just created folder dissapears when synchronizing parent folder#2559

Merged
davigonz merged 2 commits into
masterfrom
fix/folder_disappears
Jun 10, 2019
Merged

Fix just created folder dissapears when synchronizing parent folder#2559
davigonz merged 2 commits into
masterfrom
fix/folder_disappears

Conversation

@davigonz

Copy link
Copy Markdown
Contributor

Fix #2536

@davigonz davigonz self-assigned this May 31, 2019
@davigonz davigonz requested a review from hosy May 31, 2019 10:30
@davigonz davigonz force-pushed the fix/folder_disappears branch 2 times, most recently from 873fad8 to 7838e3b Compare June 4, 2019 06:48
@davigonz

davigonz commented Jun 6, 2019

Copy link
Copy Markdown
Contributor Author

Thanks @hosy for the review. The code is approved @jesmrec, you can proceed with QA

@jesmrec

jesmrec commented Jun 10, 2019

Copy link
Copy Markdown
Member

Checks performed:

  • Creation of the folder in the app
  • Creation of the folder in the document provider (Files/Downloads)
  • Rename an av. offilne folder (regression)
  • Move an av. offilne folder (regression)

Android 9

@jesmrec

jesmrec commented Jun 10, 2019

Copy link
Copy Markdown
Member

Do you miss something in the checks above, @davigonz? if not, approved on my side.

@davigonz davigonz force-pushed the fix/folder_disappears branch from 05ee7aa to 807c098 Compare June 10, 2019 12:53
@davigonz

Copy link
Copy Markdown
Contributor Author

Do you miss something in the checks above, @davigonz? if not, approved on my side.

No, it looks good to me

@jesmrec

jesmrec commented Jun 10, 2019

Copy link
Copy Markdown
Member

Approved then

@davigonz davigonz merged commit 897db03 into master Jun 10, 2019
@delete-merged-branch delete-merged-branch Bot deleted the fix/folder_disappears branch June 10, 2019 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Just created folder disappears when synchronizing parent folder

3 participants