Skip to content

Get rid of Android 4.4 support#2748

Merged
davigonz merged 2 commits into
masterfrom
feature/stop_supporting_android_kitkat
Dec 17, 2019
Merged

Get rid of Android 4.4 support#2748
davigonz merged 2 commits into
masterfrom
feature/stop_supporting_android_kitkat

Conversation

@abelgardep
Copy link
Copy Markdown
Contributor

@abelgardep abelgardep commented Dec 3, 2019 •
edited
Loading

Implements #2738
Library owncloud/android-library#285

@abelgardep abelgardep mentioned this pull request Dec 3, 2019
Merged
@davigonz davigonz mentioned this pull request Dec 3, 2019
Closed
@abelgardep abelgardep changed the base branch from master to new_arch/modularization_tests_cleanup December 3, 2019 13:58
@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented Dec 4, 2019

switch base branch to master?

@abelgardep
Copy link
Copy Markdown
Contributor Author

abelgardep commented Dec 4, 2019

switch base branch to master?

Yes, but needs modularization to be merged first. 👍

@abelgardep abelgardep changed the base branch from new_arch/modularization_tests_cleanup to new_arch/modularization December 5, 2019 07:10
@davigonz davigonz force-pushed the new_arch/modularization branch 2 times, most recently from 7f2f4ef to a316cff Compare December 5, 2019 09:07
@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented Dec 10, 2019

Smoke needed.

@jesmrec jesmrec added this to the 2.15 milestone Dec 10, 2019
@abelgardep abelgardep force-pushed the feature/stop_supporting_android_kitkat branch from 6cad26d to c71f07c Compare December 10, 2019 14:00
@davigonz davigonz force-pushed the new_arch/modularization branch 2 times, most recently from 07d1ce5 to 456d2c5 Compare December 10, 2019 17:46
@abelgardep abelgardep changed the base branch from new_arch/modularization to master December 11, 2019 11:16
@abelgardep abelgardep force-pushed the feature/stop_supporting_android_kitkat branch from c71f07c to 5658b45 Compare December 11, 2019 11:22
@abelgardep abelgardep requested a review from davigonz December 11, 2019 11:27
@abelgardep abelgardep force-pushed the feature/stop_supporting_android_kitkat branch 2 times, most recently from ecab6ad to c55a3f9 Compare December 11, 2019 11:39
davigonz
davigonz suggested changes Dec 12, 2019
View reviewed changes
Comment thread owncloudApp/src/main/java/com/owncloud/android/utils/UriUtils.java Outdated
@davigonz
Copy link
Copy Markdown
Contributor

davigonz commented Dec 12, 2019

@abelgardep just a tiny change

@abelgardep
Copy link
Copy Markdown
Contributor Author

abelgardep commented Dec 12, 2019 •
edited
Loading

@abelgardep just a tiny change

Done @davigonz

@davigonz
Copy link
Copy Markdown
Contributor

davigonz commented Dec 12, 2019

@jesmrec code approved, ready to test

@davigonz davigonz force-pushed the feature/stop_supporting_android_kitkat branch from 0476f25 to aae7402 Compare December 16, 2019 10:54
@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented Dec 16, 2019 •
edited
Loading

just to be sure: users with a 4.4 android version...

  • ...will not be able to install the app from scratch, because it will not appear neither in Google Play nor in FDroid. If they try to build the app, they can not install because the version is older than the sdkMinVersion set in the build.gradle
  • ...will not be able to upgrade to 2.15 in case they had already installed the app. They will keep the 2.14 forever.

is this correct? do i miss any other scenario?

@jesmrec jesmrec removed the Sprint label Dec 16, 2019
@davigonz
Copy link
Copy Markdown
Contributor

davigonz commented Dec 17, 2019 •
edited
Loading

will not be able to install the app from scratch, because it will not appear in Google Play

Correct

will not be able to install the app from scratch, because it will not appear in FDroid

I think so, although I'm not sure how F-droid handles minSdkVersion. But I would expect the same behaviour as in Google Play.

If they try to build the app, they can not install because the version is older than the sdkMinVersion set in the build.gradle

That's right, I've just tried it and ...

Screenshot 2019-12-17 at 10 22 06

...will not be able to upgrade to 2.15 in case they had already installed the app. They will keep the 2.14 forever.

Yes, I get the same error as in the previous image when updating the app.

@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented Dec 17, 2019

Checks performed:

  • Install the current branch in Android 4.4 -> not posible
  • Upgrade to the current branch from latest stable in Android 4.4 -> not posible
  • Smoke test over Android > 4.4

Everything OK.

@davigonz davigonz force-pushed the feature/stop_supporting_android_kitkat branch from aae7402 to f2b7f65 Compare December 17, 2019 16:34
@davigonz davigonz merged commit 6c4dfeb into master Dec 17, 2019
@davigonz davigonz deleted the feature/stop_supporting_android_kitkat branch December 17, 2019 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@davigonz davigonz davigonz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@abelgardep abelgardep

Labels

Approved by qa

Projects

None yet

Milestone

2.15

Development

Successfully merging this pull request may close these issues.

3 participants

@abelgardep @jesmrec @davigonz