update Room schema 28#2779
Merged
Merged
Conversation
This was referenced Jan 3, 2020
Contributor
|
Yes, you are right. Database changed but not the schema. I included it in #2756 |
Contributor
Author
|
Good. |
abelgardep
approved these changes
Jan 10, 2020
Contributor
abelgardep
left a comment
abelgardep
left a comment
There was a problem hiding this comment.
Thanks @hannesa2, moving this forward.
Contributor
|
Nothing to teste here... app builds correctly and CI passes. Ready to go. |
davigonz
force-pushed
the
RoomScript28
branch
from
2338d97 to
c7ed04c
Compare
Contributor
|
Merged, thanks @hannesa2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You changed with 348dcc0 for 2.14.1 the database structure by removing from
@ColumnInfo(name = CAPABILITIES_SHARING_PUBLIC_EXPIRE_DATE_DAYS, defaultValue = "0")thedefaultValue.As follow up, room changed the database structure and this changed file was ignored. -sad-
Because ownCloud use
exportSchema = trueroom is now no more able to open the database -sad-The tests were fine, because I guess, you do only
InMemorydatabase tests. But I didn't checked this.I don't use the GooglePlaystore and I don't know if you already rolled out this version. If you did it, I would not surprised about a disaster. But I don't know, so please double check this.
This pull request is to demonstrate the changes, and for me it works (because I'm able to make my fixes). But maybe you have to increase database version, make probably a migration fix too and ignore this pull request. But this is out of this pull request scope