Skip to content

Bump Koin 3.1#3531

Merged
abelgardep merged 4 commits intomasterfrom
Koin-3.1
May 4, 2022
Merged

Bump Koin 3.1#3531
abelgardep merged 4 commits intomasterfrom
Koin-3.1

Conversation

@hannesa2
Copy link
Copy Markdown
Contributor

@hannesa2 hannesa2 commented Jan 30, 2022

For future use of api31 ownCloud is prepared now.
Btw, there is a merge request in Koin InsertKoinIO/koin#1228 when it's merged, there is no workaround anymore necessary

@hannesa2 hannesa2 mentioned this pull request Jan 30, 2022
Closed
tripplehay
tripplehay reviewed Jan 30, 2022
View reviewed changes
Copy link
Copy Markdown

@tripplehay tripplehay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me

@hannesa2
Copy link
Copy Markdown
Contributor Author

hannesa2 commented Jan 31, 2022 •
edited
Loading

I see, it needs in advance

@hannesa2 hannesa2 force-pushed the Koin-3.1 branch 2 times, most recently from 0e3921f to 03481d0 Compare April 7, 2022 12:33
@abelgardep
Copy link
Copy Markdown
Contributor

abelgardep commented Apr 7, 2022

@hannesa2 don't worry about rebases, I will take care of them 👍 We have some "easy" dependencies to merge first. Later I will check the ones that require a little more attention like this one

@fesave fesave self-assigned this Apr 22, 2022
@fesave fesave force-pushed the Koin-3.1 branch 3 times, most recently from 0120952 to 80239db Compare April 26, 2022 07:53
@fesave fesave requested review from abelgardep and davcres April 26, 2022 10:14
davcres
davcres approved these changes Apr 26, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@davcres davcres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented Apr 26, 2022

Something to test here?

@fesave
Copy link
Copy Markdown
Contributor

fesave commented Apr 26, 2022

Something to test here?

Although most of the changes have been in the tests, there have also been changes in the following classes:

  • CameraUploadsWorker.kt
  • OldLogCollectorWorker.kt
  • UploadFileFromContentUri.kt
  • SyncProfileOperation.kt
  • AvatarManager.kt

If you can take a quick look and get everything working correctly, that would be great.

@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented May 4, 2022 •
edited
Loading

CameraUploadsWorker.kt / UploadFileFromContentUri.kt -> Checks in camera upload feature

  • no only wifi, no charging -> upload
  • only wifi, no charging -> upload
  • only wifi, charging (without charging) -> no upload, only queued

OldLogCollectorWorker.kt

Create logs from 4th, 5th, 6th May.
Switch device date to 13th May -> 4th and 5th removed ✅
Switch date to 22th May -> 13th removed ✅

SyncProfileOperation.kt / AvatarManager.kt

  • Update User info (display name)
  • Update quota
  • Update avatar

@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented May 4, 2022

Checks passed. Go ahead

@abelgardep abelgardep merged commit 19c06c4 into master May 4, 2022
@abelgardep abelgardep deleted the Koin-3.1 branch May 4, 2022 14:35
@abelgardep abelgardep removed the Sprint label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abelgardep abelgardep Awaiting requested review from abelgardep

2 more reviewers

@tripplehay tripplehay tripplehay approved these changes

@davcres davcres davcres approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fesave fesave

Labels

Approved by qa Estimation - 3 (M)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hannesa2 @abelgardep @jesmrec @fesave @tripplehay @davcres