Replace livedata with stateflow in camera uploads screens#3593
Merged
abelgardep merged 1 commit intomasterfrom Apr 25, 2022
Merged
Replace livedata with stateflow in camera uploads screens#3593abelgardep merged 1 commit intomasterfrom
abelgardep merged 1 commit intomasterfrom
Conversation
fesave
force-pushed
the
api31
branch
3 times, most recently
from
648b726 to
9077afc
Compare
abelgardep
force-pushed
the
improvement/replace_livedata_with_stateflow
branch
2 times, most recently
from
cb34a5f to
b835454
Compare
abelgardep
force-pushed
the
improvement/replace_livedata_with_stateflow
branch
from
b835454 to
0be6eb4
Compare
fesave
approved these changes
Apr 20, 2022
Contributor
fesave
left a comment
fesave
left a comment
There was a problem hiding this comment.
Excellent improvement, this is the way 💪🏻 . LGTM
Contributor
|
Some tests regarding camera uploads. Target is observing different folders for both photo and video upload.
|
Contributor
|
also, checked how the values are observed in the UI for auto uploads videos and pictures:
|
Contributor
|
It's approved on my side |
abelgardep
force-pushed
the
improvement/replace_livedata_with_stateflow
branch
from
0be6eb4 to
5497af0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POC to start using StateFlow instead of LiveData. Several benefits including null safety.
repeatOnLifecycleAPI available since lifecycle-runtime-ktx 2.4.0, so we need to merge #3512 firstQA