Skip to content

[FEATURE] Prevent taking screenshots in Dialogs (Android 12)#3642

Merged
abelgardep merged 3 commits intomasterfrom
feature/prevent_screenshots_dialogs
May 9, 2022
Merged

[FEATURE] Prevent taking screenshots in Dialogs (Android 12)#3642
abelgardep merged 3 commits intomasterfrom
feature/prevent_screenshots_dialogs

Conversation

@davcres
Copy link
Copy Markdown
Contributor

@davcres davcres commented Apr 27, 2022

Related Issues

App: #3637


QA

@davcres davcres self-assigned this Apr 27, 2022
@davcres davcres linked an issue Apr 27, 2022 that may be closed by this pull request
9 tasks
@davcres davcres requested review from abelgardep and fesave April 27, 2022 12:44
Copy link
Copy Markdown
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes here @davcres 👍

Comment thread owncloudApp/src/main/java/com/owncloud/android/ui/dialog/BaseDialogFragment.kt Outdated
@davcres davcres closed this Apr 29, 2022
@davcres davcres force-pushed the feature/prevent_screenshots_dialogs branch from 772f702 to c98ad69 Compare April 29, 2022 09:14
@abelgardep abelgardep reopened this Apr 29, 2022
Copy link
Copy Markdown
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented May 5, 2022

These are the dialogs/views not screenshot-prevented yet in Android12:

  • Upload menu:

Screenshot 2022-05-05 at 09 02 50

  • Auto uploads warning

Screenshot 2022-05-05 at 09 04 22

  • Auto uploads behaviour

Screenshot 2022-05-05 at 09 05 01

  • Auto uploads disabled

Screenshot 2022-05-05 at 09 05 35

  • Prevent touches warning

Screenshot 2022-05-05 at 09 06 39

  • Share sheet

Screenshot 2022-05-05 at 09 07 21

any of them could be also prevented or is this a dead way?

Pixel5 Android12
d35edb53

@davcres
Copy link
Copy Markdown
Contributor Author

davcres commented May 5, 2022

any of them could be also prevented or is this a dead way?

@jesmrec I think they all can be prevented but the share sheet. I´m going to it

@davcres
Copy link
Copy Markdown
Contributor Author

davcres commented May 5, 2022

The auto uploads behaviour can´t be prevented because it is a List of preferences instead a dialog

Screenshot 2022-05-05 at 09 05 01

The share sheet can´t be prevented neither because it´s an Android element

@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented May 6, 2022

Approved.

@abelgardep abelgardep force-pushed the feature/prevent_screenshots_dialogs branch from c6e3fa2 to 261a6f4 Compare May 9, 2022 09:58
@abelgardep abelgardep merged commit 4d44cb3 into master May 9, 2022
@abelgardep abelgardep deleted the feature/prevent_screenshots_dialogs branch May 9, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Prevent taking screenshots in Dialogs (Android 12)

3 participants