Skip to content

Add specific forbidden exception to transfer errors pool#3979

Merged
abelgardep merged 2 commits intomasterfrom
technical/add_error_handling_uploads
Mar 21, 2023
Merged

Add specific forbidden exception to transfer errors pool#3979
abelgardep merged 2 commits intomasterfrom
technical/add_error_handling_uploads

Conversation

@abelgardep
Copy link
Copy Markdown
Contributor

Related Issues

Add a new message to the errors pool when uploading or doing any operation to a space where the user does not have permission.

Also, the when clause was sorted alphabetically


QA

@abelgardep abelgardep requested a review from JuancaG05 March 21, 2023 12:58
@abelgardep abelgardep self-assigned this Mar 21, 2023
@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented Mar 21, 2023

Add a new message to the errors pool when uploading or doing any operation to a space where the user does not have permission.

is this the only case covered here?

i mean, a message like No permissions or similar is more accurate than Upload not allowed, that does not give any reason about the issue. F. ex uploads_view_upload_status_failed_permission_error: this string contains Permission error, sounds clearer about what happened. What do you think?

@abelgardep
Copy link
Copy Markdown
Contributor Author

i mean, a message like No permissions or similar is more accurate than Upload not allowed

I agree 100%. But it is kind of tricky at the moment because there are a lot of strings and translated strings over there. Sometimes we just want to show the reason, sometimes we need to show the action and the reason:

For example:

  • When creating a folder: Folder could not be created because permission error
  • When uploading a file: Permission error in the notification message and the list

We can proceed with permission error or no permissions string, but the problem here is a little bit deeper

@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented Mar 21, 2023

i understand... if we can get permission error, it's OK.

So, messaging will need a look too.

@abelgardep abelgardep force-pushed the technical/add_error_handling_uploads branch from 842acb8 to e921291 Compare March 21, 2023 15:42
@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented Mar 21, 2023

👍

@abelgardep abelgardep merged commit 47eef1c into master Mar 21, 2023
@abelgardep abelgardep deleted the technical/add_error_handling_uploads branch March 21, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants