Skip to content

[FIX] Push some Actions' dependencies to fix problem with Node20#4804

Merged
jesmrec merged 3 commits intomasterfrom
fix/update_dependencies_ci
Mar 16, 2026
Merged

[FIX] Push some Actions' dependencies to fix problem with Node20#4804
jesmrec merged 3 commits intomasterfrom
fix/update_dependencies_ci

Conversation

@jesmrec
Copy link
Collaborator

@jesmrec jesmrec commented Mar 12, 2026

Some workflows are showing the following warning:

Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: gradle/actions/wrapper-validation@v3.5.0. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

There are several affected actions in the repo's workflows. Just updating them to newest versions that support such breaking change.

The wrapper-validation-action was archived last year. It has been replaced with a newer one

Problem: The Android Instrumented Test workflow uses:

uses: reactivecircus/android-emulator-runner@v2

such action is not compliant with the change, and, it does not have an update yet. We'll have to put an eye on there.

Related Issues

App:

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@jesmrec jesmrec self-assigned this Mar 12, 2026
@jesmrec jesmrec force-pushed the fix/update_dependencies_ci branch from 764877e to 8966eff Compare March 12, 2026 11:16
@jesmrec jesmrec marked this pull request as ready for review March 12, 2026 11:33
@jesmrec jesmrec requested a review from joragua March 12, 2026 11:33
Copy link
Collaborator

@joragua joragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @jesmrec! 🚀 Just one comment: I'd use the ci: prefix for the first commit since the change affects CI (workflow files). What do you think? 🤔

NOTE: We should keep an eye on reactivecircus/android-emulator-runner releases [X] and check if it will support Node24. If not, we will need to find a different action for running the emulator.

@jesmrec jesmrec force-pushed the fix/update_dependencies_ci branch from c92d179 to 9525554 Compare March 16, 2026 07:50
@jesmrec jesmrec force-pushed the fix/update_dependencies_ci branch from 5f9dc7a to 1577b71 Compare March 16, 2026 07:51
@jesmrec jesmrec requested a review from joragua March 16, 2026 07:59
Copy link
Collaborator

@joragua joragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@jesmrec jesmrec merged commit b815a2a into master Mar 16, 2026
11 checks passed
@jesmrec jesmrec deleted the fix/update_dependencies_ci branch March 16, 2026 08:25
@joragua joragua added this to the 4.8 - Current milestone Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants