Skip to content

[FEATURE REQUEST] Pull to refresh in the member list#4836

Open
joragua wants to merge 2 commits intomasterfrom
feature/pull_to_refresh_space_members
Open

[FEATURE REQUEST] Pull to refresh in the member list#4836
joragua wants to merge 2 commits intomasterfrom
feature/pull_to_refresh_space_members

Conversation

@joragua
Copy link
Copy Markdown
Contributor

@joragua joragua commented Apr 24, 2026

Related Issues

App: #4773

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@joragua joragua self-assigned this Apr 24, 2026
@joragua joragua linked an issue Apr 24, 2026 that may be closed by this pull request
9 tasks
@joragua joragua force-pushed the feature/pull_to_refresh_space_members branch from 758ad2d to 3264752 Compare April 27, 2026 11:41
@joragua joragua force-pushed the feature/pull_to_refresh_space_members branch from 3264752 to 847d833 Compare April 27, 2026 11:42
@joragua joragua marked this pull request as ready for review April 27, 2026 12:34
@joragua joragua requested a review from jesmrec April 27, 2026 12:34
Copy link
Copy Markdown
Contributor

@jesmrec jesmrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment to review @joragua

Comment thread owncloudApp/src/main/res/layout/members_fragment.xml
@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented Apr 29, 2026

QA checks:

Pull to refresh after changes in web/iOS with the following actions

Members

  • Adding a new member
  • Adding many members to check the spinner with a longer update
  • Editing role of an existing member
  • Adding expiration date to an existing member
  • Editing expiration date of an existing member
  • Removing expiration date of an existing member
  • Changing display name of an existing member
  • Adding manager permissions to an editor/viewer (change of rol and actions visible -> create, edit, remove)
  • Removing manager permissions (change of rol and actions gone -> create, edit, remove)
  • List re-arranged when some users change permissions (sorted by permission)
  • Removing member
  • Removing all members

Links

  • Adding a new link
  • Adding many links to check the spinner with a longer update
  • Changing name of an existing link
  • Editing permission of an existing link
  • Adding expiration date to an existing link
  • Editing expiration date of an existing link
  • Removing expiration date of an existing link
  • Adding manager permissions to an editor/viewer (actions visible -> create, edit, remove)
  • Removing manager permissions (actions gone -> create, edit, remove)
  • Removing link
  • Removing all links

@joragua joragua requested a review from jesmrec April 29, 2026 09:53
Copy link
Copy Markdown
Contributor

@jesmrec jesmrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving to QA!! 🚀

@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented Apr 29, 2026

(1)

  1. Open the Space members view with a user that is a space viewer that contains links -> all links without trashbin icon
  2. In the web, user another manager account, change the user to manager
  3. In the Space members, pull to refresh

Current:

+ is now visible because user is a manager, but trashbin icons are still gone. If you go out of Space members view and enter again (other way to refresh), trashbin icons are there.

Expected:

Trashbin icons are there, because the manager permission allows the user to remove any link.

Xiaomi Redmi Note 13, Android 15
847d8335b

@jesmrec
Copy link
Copy Markdown
Contributor

jesmrec commented Apr 29, 2026

I will move this issue to blocked. Detection of (1) makes the testing to make more sense once the complete set of operations over links is done. At this moment, edit link is not finished yet.

I'd rather to do the testing once all the stuff related with the view is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Pull to refresh in the member list

2 participants